Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758785AbdCVFpG (ORCPT ); Wed, 22 Mar 2017 01:45:06 -0400 Received: from mail-yw0-f176.google.com ([209.85.161.176]:34452 "EHLO mail-yw0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758693AbdCVFov (ORCPT ); Wed, 22 Mar 2017 01:44:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170320035831.10762-1-kai.heng.feng@canonical.com> <20170320150845.7rltrhycdkk2mza4@sirena.org.uk> <20170320160622.5s2oqdyluvanjp2u@sirena.org.uk> <20170320172647.t7qacxqcgawe7xlf@sirena.org.uk> From: Kai-Heng Feng Date: Wed, 22 Mar 2017 13:44:49 +0800 Message-ID: Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode To: Bard Liao Cc: Mark Brown , Liam Girdwood , Oder Chiou , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 39 On Tue, Mar 21, 2017 at 5:15 PM, Bard Liao wrote: >> -----Original Message----- >> From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com] >> Sent: Tuesday, March 21, 2017 1:26 PM >> To: Mark Brown >> Cc: Liam Girdwood; Bard Liao; Oder Chiou; alsa-devel@alsa-project.org; >> linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell >> XPS 9343 I2S mode >> > >> >> I had the same thought originally, but printk under each case suggests >> >> otherwise - _POST_PMU is triggered not right after _PRE_PMU but right >> >> before _PRE_PMD. >> > >> > Then you've broken something else on your system, that is obviously >> > completely nonsensical and would break anything that relies on having a >> > _POST_PMU event. Why would we have two events that run at the same >> time >> > one of which is obviously misnamed? >> >> Hmm, that's weird though. I did the same test to rt286_spk_event() >> (without applying the patch I sent), what I observed was the same: >> _POST_PMU was triggered right after I stopped play sound, i.e. right >> before _PRE_PMD not right after _PRE_PMU. >> > > Although I don't think it will happen on my side, but I still > ran the same test as you. The result is just as what we > expected, _PRE_PMU and _POST_PMU run on powering > up stage and _PRE_PMD and _POST_PMD run on powering > down stage. Please check what's going on with your system. > Maybe mine is broken, maybe other XPS 9343 share the same behavior. I guess we need more users to provide information to continue the discussion. > >> ------Please consider the environment before printing this e-mail.