Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758872AbdCVHb7 (ORCPT ); Wed, 22 Mar 2017 03:31:59 -0400 Received: from conssluserg-02.nifty.com ([210.131.2.81]:54451 "EHLO conssluserg-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757351AbdCVHbJ (ORCPT ); Wed, 22 Mar 2017 03:31:09 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com v2M7UwSi006811 X-Nifty-SrcIP: [209.85.161.181] MIME-Version: 1.0 In-Reply-To: <1490106781-3129-1-git-send-email-piotrs@cadence.com> References: <1490106736-2242-1-git-send-email-piotrs@cadence.com> <1490106781-3129-1-git-send-email-piotrs@cadence.com> From: Masahiro Yamada Date: Wed, 22 Mar 2017 16:30:56 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v5 2/4] dt-bindings: mmc: add description of PHY delays for sdhci-cadence To: Piotr Sroka Cc: linux-mmc , Adrian Hunter , Ulf Hansson , Linux Kernel Mailing List , Rob Herring , Mark Rutland , devicetree@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 40 2017-03-21 23:33 GMT+09:00 Piotr Sroka : > DTS properties are used instead of fixed data > because PHY settings can be different for different chips/boards. > Add description of new DLL PHY delays. > > Signed-off-by: Piotr Sroka > --- > Changes for v2: > - file was created in v2. It was a part of driver source file patch. > - most delays were moved from dts file > to data associated with an SoC specific compatible > - description of delays was updated to be more clearly > --- > Changes for v3: > - move all delays back to dts because they are also boards dependent > - prefix all of the Cadence-specific properties with cdns prefix > --- > Changes for v4: > - change the beginning of the commit subject > --- > Changes for v5: > - change name of property to be consistent with timing modes > available in Linux As I gave Reviewed-by in v4 already, this looks good to me. Reviewed-by: Masahiro Yamada As I said before, once you get Reviewed/Acked tags, please include them in your later version. -- Best Regards Masahiro Yamada