Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933747AbdCVHcz (ORCPT ); Wed, 22 Mar 2017 03:32:55 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35725 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758915AbdCVHc0 (ORCPT ); Wed, 22 Mar 2017 03:32:26 -0400 Subject: Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command To: Arnaldo Carvalho de Melo References: <1489978617-31396-1-git-send-email-treeze.taeung@gmail.com> <1489978617-31396-5-git-send-email-treeze.taeung@gmail.com> <20170321143728.GD3641@kernel.org> <80581369-94ad-b921-174e-5b981126ccf0@gmail.com> <20170321182950.GE3641@kernel.org> <20170321183229.GF3641@kernel.org> Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan , Masami Hiramatsu , Jiri Olsa From: Taeung Song Message-ID: Date: Wed, 22 Mar 2017 16:32:20 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170321183229.GF3641@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 36 On 03/22/2017 03:32 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu: >>> On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: >>>>> +++ b/tools/perf/util/annotate.c >>>>> @@ -1443,7 +1443,7 @@ int symbol__disassemble(struct symbol *sym, struct map *map, const char *arch_na >>>>> snprintf(command, sizeof(command), >>>>> "%s %s%s --start-address=0x%016" PRIx64 >>>>> " --stop-address=0x%016" PRIx64 >>>>> - " -l -d %s %s -C %s 2>/dev/null|grep -v %s|expand", >>>>> + " -l -d %s %s -C %s 2>/dev/null|grep -v %s: |expand", >> >>>> Are you sure this works as you expect? I.e. both lines will have '%s:' >> >>> Yes, if we do, we can exactly the only below line without the side effect >>> IMHO. >> >> yeah, because the .c is not there, ok gotcha, will get your new commit >> log message, massage it a bit and apply the patch. > > Nah, with all this in mind, the original message is good enough, sorry > for the confusion with the .c and the space after ':' (that I removed, > needless and potentially confusing, as we saw here). > > - Arnaldo I got it! Thanks for your review, will also resend v2 with the rest bugfix patches making the commit log messages of them be more clearly. :) Thanks, Taeung