Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759016AbdCVIoh convert rfc822-to-8bit (ORCPT ); Wed, 22 Mar 2017 04:44:37 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:36883 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758804AbdCVIoK (ORCPT ); Wed, 22 Mar 2017 04:44:10 -0400 From: Lionel DEBIEVE To: Steven Rostedt , Thomas Gleixner CC: "linux-rt-users@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bigeasy@linutronix.de" , Patrice CHOTARD , Greg Kroah-Hartman , Jiri Slaby Subject: Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware Thread-Topic: [PATCH RT] tty: serial: st-asc: Make the locking RT aware Thread-Index: AQHSouhtQHu2Ruqu0UaPfrpMM3+k3Q== Date: Wed, 22 Mar 2017 08:43:50 +0000 Message-ID: <99a6d117-4998-fe37-5e32-ef773597e8e9@st.com> References: <1490112340-29772-1-git-send-email-lionel.debieve@st.com> <20170321144437.569440c2@vmware.local.home> <20170321161533.44c4df87@vmware.local.home> In-Reply-To: <20170321161533.44c4df87@vmware.local.home> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="Windows-1252" Content-ID: <3A1AF79AFB3F6A4F903795CF30682228@st.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-22_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 35 Just to agree with Thomas. Do you want me to resend the patch without RT tag? BR, Lionel On 03/21/2017 09:15 PM, Steven Rostedt wrote: > On Tue, 21 Mar 2017 19:51:47 +0100 (CET) > Thomas Gleixner wrote: > >> On Tue, 21 Mar 2017, Steven Rostedt wrote: >>>> /* >>>> * Disable interrupts so we don't get the IRQ line >>>> bouncing >>> I'm nervous about the above comment, which in full is: >>> >>> /* >>> * Disable interrupts so we don't get the IRQ line bouncing >>> * up and down while interrupts are disabled. >>> */ >>> >>> I'm not sure if disabling interrupts helps on an SMP system. This >>> patch does change what happens when port->sysrq is set. But I'm not >>> sure we care. >> It disables interrupts at the device level which obviously helps >> whether on SMP or not. >> > OK, so this has nothing to do with the local_irq_save() that is being > removed, which would be fine then. > > > -- Steve >