Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934022AbdCVJiB (ORCPT ); Wed, 22 Mar 2017 05:38:01 -0400 Received: from mga01.intel.com ([192.55.52.88]:58665 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933627AbdCVJhs (ORCPT ); Wed, 22 Mar 2017 05:37:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,204,1486454400"; d="asc'?scan'208";a="1145516661" From: Felipe Balbi To: "Nicholas A. Bellinger" , Manish Narani Cc: gregkh@linuxfoundation.org, xypron.glpk@gmx.de, mnarani@xilinx.com, bart.vanassche@sandisk.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, anirudh@xilinx.com, svemula@xilinx.com, target-devel Subject: Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request In-Reply-To: <1490080292.8236.99.camel@haakon3.risingtidesystems.com> References: <1490002529-24340-1-git-send-email-mnarani@xilinx.com> <1490080292.8236.99.camel@haakon3.risingtidesystems.com> Date: Wed, 22 Mar 2017 11:23:58 +0200 Message-ID: <87var1u0k1.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2233 Lines: 65 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, "Nicholas A. Bellinger" writes: > Hi Manish, > > (Added target-devel CC') > > On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote: >> This patch corrects the argument in usb_ep_free_request as it is >> mistakenly set to ep_out. It should be ep_in for status request. >>=20 >> Signed-off-by: Manish Narani >> --- >> drivers/usb/gadget/function/f_tcm.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >>=20 >> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/fu= nction/f_tcm.c >> index d235113..a82e2bd 100644 >> --- a/drivers/usb/gadget/function/f_tcm.c >> +++ b/drivers/usb/gadget/function/f_tcm.c >> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu) >> usb_ep_free_request(fu->ep_in, fu->bot_req_in); >> usb_ep_free_request(fu->ep_out, fu->bot_req_out); >> usb_ep_free_request(fu->ep_out, fu->cmd.req); >> - usb_ep_free_request(fu->ep_out, fu->bot_status.req); >> + usb_ep_free_request(fu->ep_in, fu->bot_status.req); >>=20=20 >> kfree(fu->cmd.buf); >>=20=20 > > Applied to target-pending/master. Oh, so you're taking patches for f_tcm? Fair enough: Acked-by: Felipe Balbi =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAljSQq4ACgkQzL64meEa mQY6VQ/+Pu64I0wnoUqCoXpyE0T3rptI7UsHc/SbxRoQ3ls73vJVscyP9LHzY0Kw Z/VoRwnlmux5zyzsVTBcggLLRjFShLKkI9b/Gsj1GQcnmMHaTLz8m15kzZeEsvSo yjLGb092MbUOlv2YCsGGJyMixREuriMjsl6uChNbQaRykhYwrVEpmIEQeD8bIZyl hJp977mKZUL9PYQWaM0mxWq/c2c7bi8mkVvCzZOUOE1EZpBl9vXejUZzHTZ47kN7 tIikBj96S4uGgY3h3of8ydUoTSgfvFluDa9aHd4MR/z06l1Ty8kLh9UH1UL/0tN7 YS+yGQ4wCfwicYFwxxB4g9kiidlLCoAE1sJP6Awtp8RmrunBfR2e0X1qpdivlR4D utHDqL4+U/h9ozbEb3AR7fZwvo5oLxNbKF9HKAMEZbAZHfmqLkainF4XkCHQn9kL EwTW2U/Wc63zsZFrZaWqzvf2mzKore+Q/fG6Y/AtOt1GW1PKJ1HcaadXRI4y0Qtg mINwDkp5TS2TU52QTt2UsVdKjsCO7JEMwHgFgSp+0WZLy5nmYdgSTo/BM95q4Li/ VhKN+LoRlINGBtBKrYqlR7cJBYihADxerIDsHSTKcVmV2m4M4y4ob5NqQPvpsYTy 0OScOIDAWpYSJDDnbDOaNnvZq2cXm/dPXNnmxHY8UfSskyDy/LY= =VSAv -----END PGP SIGNATURE----- --=-=-=--