Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934075AbdCVKXi (ORCPT ); Wed, 22 Mar 2017 06:23:38 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:34830 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933720AbdCVKXa (ORCPT ); Wed, 22 Mar 2017 06:23:30 -0400 Subject: Re: [PATCH 1/5] clk: meson: Add support for parameters for specific PLLs To: Michael Turquette , sboyd@codeaurora.org, carlo@caione.org, khilman@baylibre.com References: <1489411604-18700-1-git-send-email-narmstrong@baylibre.com> <1489411604-18700-2-git-send-email-narmstrong@baylibre.com> <149013981400.54062.11268768959465562064@resonance> Cc: linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Neil Armstrong Organization: Baylibre Message-ID: Date: Wed, 22 Mar 2017 11:23:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <149013981400.54062.11268768959465562064@resonance> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 522 Lines: 20 On 03/22/2017 12:43 AM, Michael Turquette wrote: > Quoting Neil Armstrong (2017-03-13 06:26:40) [..] >> >> p = &pll->n; >> - ret = meson_clk_pll_wait_lock(pll, p); >> + /* If unreset_for_lock is provided, remove the reset bit here */ >> + if (pll->params.unreset_for_lock) { > > Small nitpick, but I find "unreset" to be confusing. Since 'reset' here > is a bit that can be set and unset, maybe use clear_reset_for_lock > instead? > > Regards, > Mike > You are right, I'll rename it. Neil