Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758917AbdCVKXs (ORCPT ); Wed, 22 Mar 2017 06:23:48 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:13847 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934043AbdCVKXb (ORCPT ); Wed, 22 Mar 2017 06:23:31 -0400 X-IronPort-AV: E=Sophos;i="5.36,204,1486422000"; d="scan'208";a="265657370" Date: Wed, 22 Mar 2017 11:23:27 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: oleg.drokin@intel.com, Andreas Dilger , James Simmons , Greg Kroah-Hartman , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] staging: media: Replace a bit shift by a use of BIT. In-Reply-To: <20170322042028.GA22848@arushi-HP-Pavilion-Notebook> Message-ID: References: <20170322042028.GA22848@arushi-HP-Pavilion-Notebook> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2035 Lines: 56 On Wed, 22 Mar 2017, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal > --- > drivers/staging/octeon/ethernet-tx.c | 4 ++-- What is the connection to media? You also seem to have picked up the Lustre maintainers, who are not relevant. julia > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c > index ff4119e8de42..f00186ac4e27 100644 > --- a/drivers/staging/octeon/ethernet-tx.c > +++ b/drivers/staging/octeon/ethernet-tx.c > @@ -381,7 +381,7 @@ int cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev) > (ip_hdr(skb)->version == 4) && > (ip_hdr(skb)->ihl == 5) && > ((ip_hdr(skb)->frag_off == 0) || > - (ip_hdr(skb)->frag_off == htons(1 << 14))) && > + (ip_hdr(skb)->frag_off == htons(BIT(14)))) && > ((ip_hdr(skb)->protocol == IPPROTO_TCP) || > (ip_hdr(skb)->protocol == IPPROTO_UDP))) { > /* Use hardware checksum calc */ > @@ -613,7 +613,7 @@ int cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device *dev) > #endif > work->word2.s.is_frag = !((ip_hdr(skb)->frag_off == 0) || > (ip_hdr(skb)->frag_off == > - 1 << 14)); > + BIT(14))); > #if 0 > /* Assume Linux is sending a good packet */ > work->word2.s.IP_exc = 0; > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170322042028.GA22848%40arushi-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. >