Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933786AbdCVLTV (ORCPT ); Wed, 22 Mar 2017 07:19:21 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:35850 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759100AbdCVLTM (ORCPT ); Wed, 22 Mar 2017 07:19:12 -0400 MIME-Version: 1.0 In-Reply-To: References: <1489469158-29185-1-git-send-email-simhavcs@gmail.com> From: Rob Clark Date: Wed, 22 Mar 2017 07:19:10 -0400 Message-ID: Subject: Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required To: Vinay Simha B N Cc: David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 48 On Wed, Mar 22, 2017 at 1:11 AM, Vinay Simha B N wrote: > hi, > > Could you please give some feedback or review comments for this patch looks good, I've pulled it into msm-next BR, -R > On 3/14/17, Vinay Simha BN wrote: >> 4 macros already defined in hdmi.h, >> which is not required to redefine in hdmi_audio.c >> >> Signed-off-by: Vinay Simha BN >> --- >> drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c >> b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c >> index a54d3bb..8177e85 100644 >> --- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c >> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c >> @@ -18,13 +18,6 @@ >> #include >> #include "hdmi.h" >> >> - >> -/* Supported HDMI Audio channels */ >> -#define MSM_HDMI_AUDIO_CHANNEL_2 0 >> -#define MSM_HDMI_AUDIO_CHANNEL_4 1 >> -#define MSM_HDMI_AUDIO_CHANNEL_6 2 >> -#define MSM_HDMI_AUDIO_CHANNEL_8 3 >> - >> /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of >> channels: */ >> static int nchannels[] = { 2, 4, 6, 8 }; >> >> -- >> 2.7.4 >> >> > > > -- > regards, > vinaysimha