Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934242AbdCVLWi (ORCPT ); Wed, 22 Mar 2017 07:22:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45754 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758983AbdCVLWb (ORCPT ); Wed, 22 Mar 2017 07:22:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 76D85C04B941 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=acme@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 76D85C04B941 Date: Wed, 22 Mar 2017 08:22:07 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: Ravi Bangoria , alexis.berlemont@gmail.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, mpe@ellerman.id.au, naveen.n.rao@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com Subject: Re: [PATCH 3/5] perf/sdt/x86: Move OP parser to tools/perf/arch/x86/ Message-ID: <20170322112206.GE2531@redhat.com> References: <20161214000732.1710-1-alexis.berlemont@gmail.com> <20170202111143.14319-1-ravi.bangoria@linux.vnet.ibm.com> <20170202111143.14319-4-ravi.bangoria@linux.vnet.ibm.com> <20170207121105.c16c1bded3f24c798eac318a@kernel.org> <58995989.9020202@linux.vnet.ibm.com> <20170321141049.GC2531@redhat.com> <20170322080018.7b9a84a9b48ed4c21a94b4bc@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170322080018.7b9a84a9b48ed4c21a94b4bc@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 22 Mar 2017 11:22:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1464 Lines: 35 Em Wed, Mar 22, 2017 at 08:00:18AM +0900, Masami Hiramatsu escreveu: > On Tue, 21 Mar 2017 11:10:49 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Tue, Feb 07, 2017 at 10:52:17AM +0530, Ravi Bangoria escreveu: > > > Thanks Masami for the review. > > > > > > On Tuesday 07 February 2017 08:41 AM, Masami Hiramatsu wrote: > > > > On Thu, 2 Feb 2017 16:41:41 +0530 > > > > Ravi Bangoria wrote: > > > > > > > >> SDT marker argument is in N@OP format. N is the size of argument and > > > >> OP is the actual assembly operand. OP is arch dependent component and > > > >> hence it's parsing logic also should be placed under tools/perf/arch/. > > > >> > > > > Ok, I have one question. Is there any possibility that N is different > > > > size of OP? e.g. 8@dil, in this case we will record whole rdi. > > > > is that OK? > > > > > > By looking at list of markers on my x86 Fedora25 box, yes, it's possible > > > for case when register size used in OP is more than size specified by N. > > > For example, -4@68(%rbx). But I don't see any argument which specifies > > > higher size in N compared to size of register in OP, like you mentioned > > > in your example. > > > > Masami, can I have your Acked-by for 3-5/5 in this series? > > Arnaldo, as I reviewed, this patch still have some discussion points. > Others are good to me. That is ok, waiting for the next steps then. Thanks for the update, - Arnaldo