Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759634AbdCVNJV (ORCPT ); Wed, 22 Mar 2017 09:09:21 -0400 Received: from mail-he1eur01on0123.outbound.protection.outlook.com ([104.47.0.123]:26048 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759407AbdCVNHw (ORCPT ); Wed, 22 Mar 2017 09:07:52 -0400 Authentication-Results: infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=none action=none header.from=nokia.com; From: Tommi Rantala To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin CC: , Tommi Rantala Subject: [PATCH 4/6] perf utils: use sizeof(buf)-1 in readlink() call Date: Wed, 22 Mar 2017 15:06:22 +0200 Message-ID: <20170322130624.21881-5-tommi.t.rantala@nokia.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170322130624.21881-1-tommi.t.rantala@nokia.com> References: <20170322130624.21881-1-tommi.t.rantala@nokia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [131.228.32.186] X-ClientProxiedBy: DB6P191CA0022.EURP191.PROD.OUTLOOK.COM (10.175.236.160) To DB6PR0701MB2358.eurprd07.prod.outlook.com (10.168.75.12) X-MS-Office365-Filtering-Correlation-Id: 0511b0c9-7963-4e3b-0ed2-08d47124470d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:DB6PR0701MB2358; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;3:PcEuKoB9QMZ8wwNSR8FJ1bjEvdyEk41Xle0c6bQzJWifY3qDEzCDwBgghbmJURCeMijrf2nDiNIDfFM1WuiSqyRSQ6WP/dhIYNWJdSkUl39HKoydObcl4RqMVwOyWb62qG6ctHfe4d+cH2H95CRkbz6SKYgCAMMFeJyMgtBfjBx7Ydik7BIwx2PxSqcfV+d5JKh5yv2l2MdOj2yQt5WFTpAS4+oR6A5ofL3cpypeY9HxkT5ClLqqZylRh/b51phTx2RoPwYxeL30j/c8E8cPyLW9BuXqXz5xAyCllWk7Tts=;25:DrXOs3YCfa8aWeqxJ3TM9Ij+DpNuX9CxD+WInFaS14u56gTVst7g7VOrGyUamHGOPeYJv1yjBF0GR0flLl4EMlC32J9ZbnrFt42hZKcYzgm8Crf1q+vh1ZOoB4oSsbiO8wJGM1gSEnr8eGZIMwEKoouevhpldN4yfk9eFIz3/cv0GlBKOEJeJB4s145YAbYaFqg2doyW1fNPemUWYlmooB4VnYDVeBUtGm8goqW0VpFodk/yilwznT66l9TlWjcb8ZfG2n0SFArCb/4ua9oNzdubRiXjoZ+R77alQUTkeBfa4hFEugzGA0bxYonFbMIoedYbM735NJafcZdIBOiEzONFlFpLrF5mhBOq0P3SrGcAVvCYHl76OStuSyUYTv44B5VY+u7pRxnNOs1qLeGlFMSBJbDgEVeB9yTpVlH1nWnw+qNqEjsP+pHDPkzcmX6KeUtozc12IHZAdR8Qubwr6w== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;31:gt1QO6YpJtQfdisGAKQ2Nlc2D2zEWWFj985t2ApEk5CEOC+uGPKOciGaboox920Fcf3LJwtIJPKu41hRwXQfH+irYpm9vf5kFUGWiXjs2gDccCk1VnEBzw0n98xioCqx7VQ4dQgKwmC18X97LVeb8IX04RFcWT9FWT0EFlN2qMgHAeJWILLIz+fZ/9ef5nRY5ts9WwghCTOohAly5YGtGg+bvXuqxsFmDKLXMCYcvo8=;20:ZuO3WGPD4uhNTCT/XT2BnWo28+86WtkpRyWgemcqzzAcr6Xk3d4ziyiEnLwIhkBxsfiKBWx7ukeX+352Eow2g0qiY7szqXWqLdXtmY0CL7XTaephT1MNv5mvgRWhtTM0oBkHSYnPPBPUpFcyfLsTS9KbBcWqafJDuqZIg1hnoNpzQJKU98IUHY6TLNdp4bY9aZYn6xt2GinJ7MJY3sVwyM/hnK5eM48drbWZRII2p9pvMX2ktt2R+JczwsfyNjYGORRN1sikSV6jDBQkKAyXrHnvbh49PN2xpbMoS9N37eBIQp4MbCk7q3aLTh4eAjqlhh3nncKM3BdvaJUKqxU50bDA0HllvEB/LRiLnU1nRPizfgiGw0Hnql6Ckcq+AuO+GH24tU3/FaI5FtzwuMgkd5Gaosdtu+zpiCufqogwdDX7UD4UjMri1zD9DR65jzyXMJ717+j/3E3W0ybbide+vUbPq0UNyBvwDklmhS779lOPlzKUlF+m66JN44kmnsdc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(82608151540597); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123558025)(20161123555025)(6072148);SRVR:DB6PR0701MB2358;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0701MB2358; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;4:4BnTHL8qBQtMdfKlbzSdLzgWNy/kN1A25UpMTbU0dLXhS7OFXxeG6+mFulB+qZhllyAhMBbb+dnhDCLKiGRoCwzua+xf9vqcHXUBIiLApaEAzjcvpWT/q7HUW/o5irHwyokLY9l5KsGFCoEI3s92BcXMN6dPVMKzD8G0cj0JKqon98C6XxONLCZnEVS7R+NdN3Uxm0/NNMtaarvqKcTz6sF6FPal+RdYq1k1qalqYdFzGHK2EK0iwq4xO8N+NSfjPAyvkaOR+XcrzcZDgyWO1WfKP0J/YaLeCSCWCsUUrSHk+Tt6Cuu+ILO/Z4WEE6zkdjMH62P74ZruVjtgjZ+l8xDLTjKvcUPmSyB+YtN0j1MoZIkKtvwgbOf+11TXisD8j9bBDj/z7Egzeptdo/Soy9sIuE29+LBr5DMfVopmL3UsgGN5CkQOmWB0cF/HDpQfYaofxLUigYlG5OqCBAfAGNEgufZ+MBb5QRKU3p0bN6XkTSjRhzGxYk7uAeueySIHwddTWBJixm3ERW1uQSPhQXNgtLds/tKcm8ZSXKnbbL4IZSEvxlBphk67fWX3zlc/5HfyKEmmfC/HUEaifjKbwhNQYwk0gGNbH8VpP910hF1VYHka31kbfYxoyrO3/xnh5euThVBK7x+hfVaL2a5dv9QDuUnrZsCqp6aMXg2Z1Dc= X-Forefront-PRVS: 02543CD7CD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39840400002)(39860400002)(39410400002)(39450400003)(39850400002)(50466002)(66066001)(42186005)(6486002)(6506006)(81166006)(2950100002)(6666003)(47776003)(5003940100001)(8676002)(6512007)(5660300001)(2906002)(103116003)(50986999)(76176999)(25786009)(4326008)(36756003)(38730400002)(107886003)(1076002)(189998001)(50226002)(33646002)(53936002)(3846002)(6116002)(48376002)(7736002)(305945005)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0701MB2358;H:trfedora.emea.nsn-net.net;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0701MB2358;23:ukWhDVfAkl31w8bLzfp8yMTD8lBYyEZL6KDa0Np?= =?us-ascii?Q?l7YlxV/l8fXWjenCO5x+fJPr+AthS4GdKckrxZ0q+74agBjbzx3d2LNjG7wZ?= =?us-ascii?Q?fpGRXHLXu7pXuZjjdHsvOtn/8vedM4dFqwAW6l0wUmwvOnh3UnkYlFSJMswT?= =?us-ascii?Q?M+fhIcUhXWnX91OIF5vkZs86DKVg8UEgAc7HOKD+UqYXl2fPuo7593iTGIB6?= =?us-ascii?Q?eBRGhCT/ZfD6EOkAdInPgSzLgiOkBbBMYZl6ecYqtND3FNpBZNJdoUHa7eUA?= =?us-ascii?Q?EAd4BId7ryJtPHHcNY8u8vjQgQ87Zt3aFdK3wpPx8zhV6cOvBfcw/In3Sb8o?= =?us-ascii?Q?dxNW5c8DqXR4NJGiWX7ACZh9HwytIgSadPEwZgrkHtgaX4E/cxYsJf3nT8lu?= =?us-ascii?Q?4EDYXC0Mfwt9bYzaWkUGVjRWr1YiXavDzzL9N3yl4gNrux2jt55IsEVa8Rzs?= =?us-ascii?Q?aveIwgv77EFOZgFeycRZXUWzcjVGUKN12vfWOaUXRvIz7VAVjrUeykkObkHf?= =?us-ascii?Q?KR544GsT18/RaQftVtbAGPN+/VU5jH2QvRdBJjEZdL9KRb0Q2yFkYRdQCoZp?= =?us-ascii?Q?CZtX3p/9AhPzT7zMqfAfUAQAADC16fhM5uZ2N7HAVqjcDCSy06FVrISCQjsA?= =?us-ascii?Q?ges3GkBaEn5YnCf3kMrYekKN9gkXDItEi+AFx6wID02H75tu5Ge9kYnm3NSY?= =?us-ascii?Q?K46rklOb93+aBVmFxUOAg82KKVo5D5rI6UWMmcjJdMKtyMum7HrKPp/9Y86n?= =?us-ascii?Q?x0AWCpLdjiF+Tj6je86JDjBtyDUdgJoQOeCRMfUjvg7QXD70Awij6kFuLo/b?= =?us-ascii?Q?2biZkFEwbojNTIR+mnkZSRNd5U7KiYInXRgQwzVuYVIFk0cs7bYnn3iFHw0Y?= =?us-ascii?Q?Q74pCFC+Ni1GJZNrZmAVAUVtE+k3mA1wt+8MBkqK1XBeFXPHah3T9EB0C+9B?= =?us-ascii?Q?fOp4IhPqMmsxiFy3H3/mEjdnAR9bO2y+5l4itiEQbLJe+5CFnfWHiwiv0ePx?= =?us-ascii?Q?BrtCm87JJSPI6uj8PGzNX3813D8cLETPONP0N9EFzePmtOA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;6:2AzEz/fNmzD7IhTejPyEkzcO4m2Mjs52fVhEbhGMkCdxXVAZBdaNU+qJX7L/rOeJYQhmrHj/Nhu2TkDYQ0pg6gLrHEBjrUhnQ8cWRk6cGpkYERr2YXtTYmySpWVqj6+TrpqlENB6xqpI3vdn0l9gQwjF2uh8z+NtSM3clKYolOvOD1beTddfKYIZMkc0UUSWMXyVpmXFMWF+aUPp3pB9ZEWf/NW6HazwsINVF5/bqDphLEGCCHWcOO/YTlXGRbiRwhUWflNiwhJjm1Q+Wj+YUbR7XPnEArKx9NESGAEVziacwDbN+fh0o9rQOg6BkKrti97vQS477CKFQw0sF6s1IR3+0dDDuTG+ZZv2PeT8DGtVE9xVOCitK2wlW+G9g4qCAZu5qvQkygPckw3mVJo1IsxDv0foLo6h5E+zPaC034U=;5:nsNY/Hwq93NWW/BfmPcAj2susUQccFWA8j3jUfs+UcHCSS1/3WO1ytwxVsFI8kKQ7fnlFGeoJbDOlEWCXjTA7Ux7LLr2zPIccpXClTmMDoYLSR/hXqR95saYOQikWvoC8ZafoHveDdqpUotPNh8d0w==;24:AoAZdSVfbtlaM+MZiY4jv/DjeF7QSxxPYSkwa3AdeV8umFhTbsedDQzwhorK8UQKJrafJf1nr6yOM0uQV14/9srr6YKjxLav8UFQsplbbI0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;7:RH0Kl7j3trgFQ9sYFl8phSZqo4DDuYRC9McDeLIUcZmGp3614zYZ3Fueuttq7BYjPS8NEnco5UyCb+lFeqSZZ++1gSIZu5wuVh4eDrdH71yjNu1MNbps0cK2enDbH86Umd75Z1DFhYwlLCxCNr664b5hMWs46cb1L7qLbp4vetcPjQJAyhTTvmUdZQTeWlW90I79tMTn2lFus9pX/zFlGTifBiYCClen9w9uCcLwlsi19IwV4L6Bu2EjsJPJI5Jca/ZdIePjtqbjctERHgeLDV5wWmzwbM5ShXcodkSqs5jGL+K2r2TEt+ia1MBMHUWwicgZ+OI/ZB1z4wrY5l9mdg== X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2017 13:06:38.5857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0701MB2358 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 658 Lines: 22 Ensure that we have space for the null byte in buf. Signed-off-by: Tommi Rantala --- tools/perf/util/header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 05714d5..ab10e9d 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -378,7 +378,7 @@ static int write_cmdline(int fd, struct perf_header *h __maybe_unused, * actual atual path to perf binary */ sprintf(proc, "/proc/%d/exe", getpid()); - ret = readlink(proc, buf, sizeof(buf)); + ret = readlink(proc, buf, sizeof(buf)-1); if (ret <= 0) return -1; -- 2.9.3