Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759385AbdCVNMQ (ORCPT ); Wed, 22 Mar 2017 09:12:16 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:33796 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109AbdCVNMG (ORCPT ); Wed, 22 Mar 2017 09:12:06 -0400 MIME-Version: 1.0 In-Reply-To: <1490026491-21742-5-git-send-email-jacopo+renesas@jmondi.org> References: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org> <1490026491-21742-5-git-send-email-jacopo+renesas@jmondi.org> From: Geert Uytterhoeven Date: Wed, 22 Mar 2017 14:12:04 +0100 X-Google-Sender-Auth: 01cqvNfTpFAssrsNUAGJe4ItMvY Message-ID: Subject: Re: [PATCH v2 4/7] arm: dts: r7s72100: Add pin controller node To: Jacopo Mondi Cc: Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Linus Walleij , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1094 Lines: 36 Hi Jacopo, On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi wrote: > Add pin controller node with 12 gpio controller sub-nodes to > r7s72100 dtsi. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -183,6 +183,86 @@ > }; > }; > > + pinctrl: pinctrl@fcfe3000 { > + compatible = "renesas,r7s72100-ports"; > + > + #pinctrl-cells = <1>; > + > + reg = <0xfcfe3000 0x4248>; How did you get to 0x4248? I had expected 0x4230. Not that it matters much, Linux rounds it up to a multiple of PAGE_SIZE anyway. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds