Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759658AbdCVNV0 (ORCPT ); Wed, 22 Mar 2017 09:21:26 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:36134 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759433AbdCVNVD (ORCPT ); Wed, 22 Mar 2017 09:21:03 -0400 MIME-Version: 1.0 In-Reply-To: References: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org> <1490026491-21742-3-git-send-email-jacopo+renesas@jmondi.org> From: Geert Uytterhoeven Date: Wed, 22 Mar 2017 14:20:08 +0100 X-Google-Sender-Auth: tGDa8DwYErbMow4E0e82PPo_p1Y Message-ID: Subject: Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc To: Jacopo Mondi Cc: Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Linus Walleij , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1263 Lines: 32 On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven wrote: > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi wrote: >> Add device tree bindings documentation for Renesas RZ/A1 gpio and pin >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-pinctrl.txt ulating the pin index from its position >> + (port where it sits on and pin offset), and alternate function >> + configuration options are provided in pin controller header file at: > > the pin ... file > >> + include/dt-bindings/pinctrl/r7s72100-pinctrl.h > > Hence I'd include that file in this patch, as it's part of the bindings. Ah, that would create a hard dependency between the DTS files and the DT bindings, which typically go in through different trees. As the driver replicates the definitions from the header, the include file can go in with the DTS updates. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds