Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934884AbdCVNqH (ORCPT ); Wed, 22 Mar 2017 09:46:07 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:36647 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934182AbdCVNqA (ORCPT ); Wed, 22 Mar 2017 09:46:00 -0400 MIME-Version: 1.0 In-Reply-To: <20170322133821.GA21278@salvia> References: <1490085879-1827-1-git-send-email-singhalsimran0@gmail.com> <20170322133821.GA21278@salvia> From: SIMRAN SINGHAL Date: Wed, 22 Mar 2017 19:15:58 +0530 Message-ID: Subject: Re: [PATCH 0/5] netfilter: Clean up tests if NULL returned on failure To: Pablo Neira Ayuso Cc: kadlec@blackhole.kfki.hu, davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg KH , outreachy-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 682 Lines: 18 On Wed, Mar 22, 2017 at 7:08 PM, Pablo Neira Ayuso wrote: > On Tue, Mar 21, 2017 at 02:14:34PM +0530, simran singhal wrote: >> This patch series clean up tests if NULL returned on failure. > > $ git grep "== NULL" net/netfilter/ | wc -l > 461 > > This is cleaning up just some of them, we still seem to have quite a > bit of them. > > Main problem with this changes is that it creates lots of work to > people backporting patches and stable maintainers, I remember that > they have complain about this. > > Either way, I would prefer you fix this coding style issue in one go, > ie. one single patch, it will be a large one. ok, I will send the single patch.