From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-scsi@vger.kernel.org, vinholikatti@gmail.com,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting
 clkscaling
Date: Wed, 22 Mar 2017 14:35:45 +0100
Message-id: <10077418.cjgahspKMt@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <20170321121957.18655-1-jh80.chung@samsung.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset=us-ascii
CMS-TYPE: 105P
References: <CGME20170321121957epcas1p3ccd834d3ac572a1858684e8ab4bb24e1@epcas1p3.samsung.com>
 <20170321121957.18655-1-jh80.chung@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 996
Lines: 35


Hi,

On Tuesday, March 21, 2017 09:19:57 PM Jaehoon Chung wrote:
> There are same conditions for checking whether supporting clkscaling or
> not.
> When ufshcd is supporting clkscaling, active_reqs should be decreased by
> two.

I guess you meant "one" here, not "two"?

> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index dc6efbd..f2cbc71 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba,
>  		}
>  		if (ufshcd_is_clkscaling_supported(hba))
>  			hba->clk_scaling.active_reqs--;
> -		if (ufshcd_is_clkscaling_supported(hba))
> -			hba->clk_scaling.active_reqs--;
>  	}
>  
>  	/* clear corresponding bits of completed commands */

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics