Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935033AbdCVOPR (ORCPT ); Wed, 22 Mar 2017 10:15:17 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:36462 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934687AbdCVOOs (ORCPT ); Wed, 22 Mar 2017 10:14:48 -0400 Subject: Re: [PATCH linux-next] tty: Disable default console blanking interval To: Tim Gardner , linux-kernel@vger.kernel.org References: <1490190632-10464-1-git-send-email-tim.gardner@canonical.com> Cc: Greg Kroah-Hartman , Jiri Slaby , Adam Borowski , Scot Doyle From: "Austin S. Hemmelgarn" Message-ID: <5d5fe4d8-a4d4-c631-3991-072e176d0314@gmail.com> Date: Wed, 22 Mar 2017 10:14:45 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490190632-10464-1-git-send-email-tim.gardner@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1694 Lines: 40 On 2017-03-22 09:50, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/869017 > > Signed-off-by: Tim Gardner > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: Adam Borowski > Cc: Scot Doyle > --- > > I'm not particularly knowledgable about console issues. Is a blaknking interval > relevant in a post CRT world ? The argument in the bug description seems > compelling. Burn-in still happens on at least LCD screens (not sure about anything else except DLP, where it doesn't happen unless it's a really crappy display), but on many of those it happens regardless of the contents of the display (I've actually got an old LCD display where the image is constantly dark because of having displayed so many hours of a black screen), but displaying a black screen instead of powering off the display doesn't really save any power on most modern displays and the fact that the screen isn't un-blanked when the kernel crashes is a pretty compelling argument against having it enabled by default IMO. > > drivers/tty/vt/vt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c > index 5c4933b..9c99452 100644 > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -181,7 +181,7 @@ int console_blanked; > > static int vesa_blank_mode; /* 0:none 1:suspendV 2:suspendH 3:powerdown */ > static int vesa_off_interval; > -static int blankinterval = 10*60; > +static int blankinterval; > core_param(consoleblank, blankinterval, int, 0444); > > static DECLARE_WORK(console_work, console_callback); >