Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760148AbdCVOsF (ORCPT ); Wed, 22 Mar 2017 10:48:05 -0400 Received: from mga04.intel.com ([192.55.52.120]:10787 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759577AbdCVOr4 (ORCPT ); Wed, 22 Mar 2017 10:47:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="63666800" Subject: Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com From: Jarkko Nikula Message-ID: <390a6b71-92d4-bafe-224a-f2b2a864cabc@linux.intel.com> Date: Wed, 22 Mar 2017 16:47:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2314 Lines: 54 On 03/20/17 13:10, Luis Oliveira wrote: > - The functions related to I2C master mode of operation were transformed > in a single driver. > - Common definitions were moved to i2c-designware-core.h > - The i2c-designware-core is now only a library file, the functions > associated are in a source file called i2c-designware-common and > are used by both i2c-designware-master and i2c-designware-slave. > - To decrease noise in namespace common i2c_dw_*() functions are > now using ops to keep them private. > - Designware PCI driver had to be changed to match the previous ops > functions implementation. > > Almost all of the "core" source is now part of the "master" source. The > difference is the functions used by both modes and they are in the > "common" source file. > > Signed-off-by: Luis Oliveira > Acked-by: Andy Shevchenko > --- > v6-v7 > - Moved kernel doc comments from patch 4/6 to this patch. @Jarkko > - Fix Designware I2C PCI driver error when looking for previous extern > functions. > ... > * struct dw_i2c_dev - private i2c-designware data > @@ -78,7 +196,11 @@ > * @acquire_lock: function to acquire a hardware lock on the bus > * @release_lock: function to release a hardware lock on the bus > * @pm_runtime_disabled: true if pm runtime is disabled > - * > + * @dynamic_tar_update_enabled: true if dynamic TAR update is enabled > + * @disable: function to disable the controller > + * @disable_int: function to disable all interrupts > + * @init: function to initialize the I2C hardware > + * > * HCNT and LCNT parameters can be used if the platform knows more accurate > * values than the one computed based only on the input clock frequency. > * Leave them to be %0 if not used. > @@ -126,15 +248,31 @@ struct dw_i2c_dev { > int (*acquire_lock)(struct dw_i2c_dev *dev); > void (*release_lock)(struct dw_i2c_dev *dev); > bool pm_runtime_disabled; > + void (*disable)(struct dw_i2c_dev *dev); > + void (*disable_int)(struct dw_i2c_dev *dev); > + int (*init)(struct dw_i2c_dev *dev); > }; > I take my ack back. You are adding comment for dynamic_tar_update_enabled which was removed by the 12688dc21f71 ("Revert "i2c: designware: detect when dynamic tar update is possible"") -- Jarkko