Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760245AbdCVOv7 (ORCPT ); Wed, 22 Mar 2017 10:51:59 -0400 Received: from mga01.intel.com ([192.55.52.88]:50611 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760213AbdCVOvp (ORCPT ); Wed, 22 Mar 2017 10:51:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="1125798108" Subject: Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com From: Jarkko Nikula Message-ID: <92bee7a2-4320-cff7-ef18-9770d6fe12fe@linux.intel.com> Date: Wed, 22 Mar 2017 16:38:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1754 Lines: 35 On 03/20/17 13:10, Luis Oliveira wrote: > - The functions related to I2C master mode of operation were transformed > in a single driver. > - Common definitions were moved to i2c-designware-core.h > - The i2c-designware-core is now only a library file, the functions > associated are in a source file called i2c-designware-common and > are used by both i2c-designware-master and i2c-designware-slave. > - To decrease noise in namespace common i2c_dw_*() functions are > now using ops to keep them private. > - Designware PCI driver had to be changed to match the previous ops > functions implementation. > > Almost all of the "core" source is now part of the "master" source. The > difference is the functions used by both modes and they are in the > "common" source file. > > Signed-off-by: Luis Oliveira > Acked-by: Andy Shevchenko > --- > v6-v7 > - Moved kernel doc comments from patch 4/6 to this patch. @Jarkko > - Fix Designware I2C PCI driver error when looking for previous extern > functions. > > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-designware-common.c | 274 +++++++++++++++ > drivers/i2c/busses/i2c-designware-core.h | 146 +++++++- > ...c-designware-core.c => i2c-designware-master.c} | 367 +-------------------- > drivers/i2c/busses/i2c-designware-pcidrv.c | 8 +- > drivers/i2c/busses/i2c-designware-platdrv.c | 6 +- > 6 files changed, 433 insertions(+), 369 deletions(-) > create mode 100644 drivers/i2c/busses/i2c-designware-common.c > rename drivers/i2c/busses/{i2c-designware-core.c => i2c-designware-master.c} (64%) > Acked-by: Jarkko Nikula