Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760309AbdCVOx3 (ORCPT ); Wed, 22 Mar 2017 10:53:29 -0400 Received: from mga14.intel.com ([192.55.52.115]:25342 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760291AbdCVOxV (ORCPT ); Wed, 22 Mar 2017 10:53:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="947051734" Subject: Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <55d2ccf235080a77347ad9e3a34263ca9cc8f80d.1490007620.git.lolivei@synopsys.com> Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com From: Jarkko Nikula Message-ID: <5c17a8bb-656b-656c-0ae7-aa06f8f5116b@linux.intel.com> Date: Wed, 22 Mar 2017 16:53:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <55d2ccf235080a77347ad9e3a34263ca9cc8f80d.1490007620.git.lolivei@synopsys.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 43 On 03/20/17 13:10, Luis Oliveira wrote: > - Definitions were added to core library > - A example was added to designware-core.txt Documentation that shows > how the slave can be setup using DTS > > SLAVE related definitions were added to the core of the controller. > > Signed-off-by: Luis Oliveira > Reviewed-by: Andy Shevchenko > Acked-by: Rob Herring > --- > v6-v7 > - no changes > ... > +#define DW_IC_RX_ABRT_SLAVE_RD_INTX (1UL << ABRT_SLAVE_RD_INTX) > +#define DW_IC_RX_ABRT_SLAVE_ARBLOST (1UL << ABRT_SLAVE_ARBLOST) > +#define DW_IC_RX_ABRT_SLAVE_FLUSH_TXFIFO (1UL << ABRT_SLAVE_FLUSH_TXFIFO) > > #define DW_IC_TX_ABRT_NOACK (DW_IC_TX_ABRT_7B_ADDR_NOACK | \ > DW_IC_TX_ABRT_10ADDR1_NOACK | \ > @@ -211,6 +236,7 @@ struct dw_i2c_dev { > struct completion cmd_complete; > struct clk *clk; > struct reset_control *rst; > + struct i2c_client *slave; > u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev); > struct dw_pci_controller *controller; > int cmd_err; > @@ -230,6 +256,7 @@ struct dw_i2c_dev { > struct i2c_adapter adapter; > u32 functionality; > u32 master_cfg; > + u32 slave_cfg; > unsigned int tx_fifo_depth; > unsigned int rx_fifo_depth; > int rx_outstanding; > Here too I take my ack back. You should add comments for these added members. -- Jarkko