Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760011AbdCVPLc (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Mar 2017 11:11:32 -0400
Received: from mail-wr0-f193.google.com ([209.85.128.193]:33600 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758814AbdCVPL0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Mar 2017 11:11:26 -0400
Date: Wed, 22 Mar 2017 16:11:21 +0100
From: Ralph Sennhauser <ralph.sennhauser@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION next-20170321] acbdad8dd1ab ("serial: 8250_dw:
 simplify optional reset handling") causes silent kernel.
Message-ID: <20170322161121.2b0a4b17@gmail.com>
In-Reply-To: <1490193227.2285.39.camel@pengutronix.de>
References: <20170322152445.0b25f78c@gmail.com>
        <1490193227.2285.39.camel@pengutronix.de>
Organization: none
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1185
Lines: 41

Hi Philipp

On Wed, 22 Mar 2017 15:33:47 +0100
Philipp Zabel <p.zabel@pengutronix.de> wrote:

> Hi Ralph,
> 
> On Wed, 2017-03-22 at 15:24 +0100, Ralph Sennhauser wrote:
> > Hi Philipp,
> > 
> > Commit acbdad8dd1ab ("serial: 8250_dw: simplify optional reset
> > handling") causes the kernel to no longer print anything to the
> > serial console on a Linksys WRT3200ACM (Armada-385, a similar board
> > would be ./arch/arm/boot/dts/armada-385-linksys-cobra.dts). The
> > last message from uboot is "Starting kernel ..." and then silence.
> > The device boots all the way nonetheless.
> > 
> > Reverting the above commit gets the console output back.
> > 
> > Ralph  
> 
> Thank you for the report. I assume that you are compiling with the
> RESET_CONTROLLER Kconfig option disabled? Does commit 0ca10b60ceeb
>  [1] in
> the arm-soc fixes branch help with this issue?

Yes, RESET_CONTROLLER is not set.

Commit 0ca10b60ceeb ("reset: fix optional reset_control_get stubs to
return NULL") fixes the issue for me.

Thanks
Ralph

> 
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/commit/?h=fixes&id=0ca10b60ceeb5372da01798ca68c116ae45a6eb6
> 
> regards
> Philipp
>