Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935411AbdCVPgq (ORCPT ); Wed, 22 Mar 2017 11:36:46 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:52360 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934772AbdCVPgi (ORCPT ); Wed, 22 Mar 2017 11:36:38 -0400 Date: Wed, 22 Mar 2017 16:36:28 +0100 From: jacopo To: Geert Uytterhoeven Cc: Jacopo Mondi , Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Linus Walleij , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Message-ID: <20170322153628.GH30223@w540> References: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org> <1490026491-21742-3-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 43 Hi Geert, thanks for reviews On Wed, Mar 22, 2017 at 02:20:08PM +0100, Geert Uytterhoeven wrote: > On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven > wrote: > > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi wrote: > >> Add device tree bindings documentation for Renesas RZ/A1 gpio and pin > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-pinctrl.txt > > ulating the pin index from its position > >> + (port where it sits on and pin offset), and alternate function > >> + configuration options are provided in pin controller header file at: > > > > the pin ... file > > > >> + include/dt-bindings/pinctrl/r7s72100-pinctrl.h > > > > Hence I'd include that file in this patch, as it's part of the bindings. > > Ah, that would create a hard dependency between the DTS files and the > DT bindings, which typically go in through different trees. > As the driver replicates the definitions from the header, the include file > can go in with the DTS updates. > Sorry, got confused by multiple reviews here.. Are you suggesting to squash [03/07] in [04/07] here? Thanks j > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds