Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [PATCH] ARM: dts: rockchip: setup DMA-channels for mmc0 and emmc for rk3188
From: Alexander Kochetkov <al.kochet@gmail.com>
In-Reply-To: <11123239.Wc863F7R2R@phil>
Date: Wed, 22 Mar 2017 19:20:56 +0300
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        LAK <linux-arm-kernel@lists.infradead.org>,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Message-Id: <C2BC0A84-EF69-42E3-84FA-A873B8A7187A@gmail.com>
References: <1490109227-4006-1-git-send-email-al.kochet@gmail.com> <11123239.Wc863F7R2R@phil>
To: Heiko Stuebner <heiko@sntech.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1043
Lines: 28

Hello, Heiko!

> 22 марта 2017 г., в 18:54, Heiko Stuebner <heiko@sntech.de> написал(а):
> 
> I've applied a slightly different variant in [0] with your commit message and
> moved the dma properties to the mmc/emmc nodes in rk3xxx.dtsi - as the dma
> channels are the same on both rk3188 and rk3066.

Thank you! I had changes in the rk3xxx.dtsi initially, but them moved them
into rk3188. Don’t know why I did that. May be because I don’t have rk3066
based board to test on.

> While at it, I've also added the sdio dma as there is no need to leave it out.

I’ve tested mmc0 and emm and they work great. I haven’t tested sdio.

> 
> Also when changing the devicetree, please do not append stuff at the bottom
> but instead sort new nodes (the &mmc &emmc in this case) and properties
> alphabetically.

Ok. Thank you.

I have working settings for eMMC for radxa rock. What do you think, is it good idea to add them
to the kernel DT? As Radxa Rock doesn’t come with eMMC, but eMMC can be soldered manually.

Alexander.