Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965449AbdCVSKk (ORCPT ); Wed, 22 Mar 2017 14:10:40 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:36975 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934813AbdCVSKd (ORCPT ); Wed, 22 Mar 2017 14:10:33 -0400 X-IronPort-AV: E=Sophos;i="5.36,206,1486393200"; d="scan'208";a="237435213" From: Chris Brandt To: Jacopo Mondi , "geert+renesas@glider.be" , "laurent.pinchart@ideasonboard.com" , "linus.walleij@linaro.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux@armlinux.org.uk" CC: "linux-renesas-soc@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 0/7] Renesas RZ/A1 pin and gpio controller Thread-Topic: [PATCH v2 0/7] Renesas RZ/A1 pin and gpio controller Thread-Index: AQHSoZUoYj8Lrr93dEK6BBpD45ow26GhKMjg Date: Wed, 22 Mar 2017 18:10:26 +0000 Message-ID: References: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org> In-Reply-To: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: jmondi.org; dkim=none (message not signed) header.d=none;jmondi.org; dmarc=none action=none header.from=renesas.com; x-originating-ip: [4.59.13.106] x-microsoft-exchange-diagnostics: 1;SG2PR06MB1165;7:aPSSDcWMtSJZf0UH3fViqOFUZBzgdKnnxGw4Ju5u7jh4nQPcEykbne0VNs9Qbgg1kvcjGr6P0rI/DCVQuu22y/gQCYhbe7po/ScBtYqtTu17t1iAYXns+pi7CKFXD5R5N+p3GsgiH3WrdRbKFO7xMDPOPtnth3diQXtAjDwS4IForzntkuS+ZC+3aFLdiSlNdMZxZmtyRMvfWdwiX7pb/Woy8X1fQm9VthVviFGyyQcEiKaBOrCtSeBAW43AfXQohP7bLfRC8ULqSuhQRRl+OSE6ykJ4HAxEPUbsgskfYVk0QpNk+shMvIrwXfVBmJVH49eHw1kd7VkkhcURMd8A5g==;20:qDuWrqmyj6nPiu2dGahXM8c35xhcYK9V7a59I+NtZDEbJCMrlrdxOfWEfbaUPbKt0JOgktEfRQkw5ugy2Bc0QQO3waWHO6V2Nh2jDjOn8tyRZjhC9hnhPmOU5eSMl+S6tYMKify9w8SQ2iEbMC8uWMC+JKw7xTgXnkp6nMZ3qyM= x-ms-office365-filtering-correlation-id: b9945577-9a98-4eb5-10c5-08d4714eb762 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081);SRVR:SG2PR06MB1165; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148);SRVR:SG2PR06MB1165;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1165; x-forefront-prvs: 02543CD7CD x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(39840400002)(39450400003)(39410400002)(39850400002)(24454002)(81166006)(8936002)(86362001)(54356999)(74316002)(229853002)(7416002)(122556002)(8676002)(76176999)(50986999)(6116002)(102836003)(55016002)(3280700002)(53936002)(99286003)(3846002)(3660700001)(2950100002)(7736002)(305945005)(2906002)(33656002)(9686003)(7696004)(54906002)(66066001)(25786009)(6246003)(6436002)(6506006)(189998001)(5660300001)(77096006)(2501003)(4326008)(38730400002);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB1165;H:SG2PR06MB1165.apcprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2017 18:10:26.3033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1165 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2MIAnpB002790 Content-Length: 2679 Lines: 114 Hi Jacopo, On Monday, March 20, 2017, Jacopo Mondi wrote: > Chris: it would be great if you could give this another spin on RSK board. I tested these patches on an RZ/A1H RSK board after modifying the DT for the RSK vs the GENMAI board. The following worked fine: * SCIF * I2C * SDHI * Ethernet I see Geert has already responded with mostly text (grammar) changes. As for the "API" of the driver from a user perspective, I think it should cover all the use cases of the peripherals. For your reference, here was my pin config for the RSK board testing. Once this driver is (hopefully) accepted, I will update the upstream rskrza1 DT. --- RSK BOARD PIN SETUP --- &pinctrl { scif2_pins: serial2 { /* P3_0 as TxD2; P3_2 as RxD2 */ renesas,pins = , ; }; /* RIIC Ch 3 */ i2c3_pins: i2c3 { /* RIIC3: P1_6 as SCL, P1_7 as SDA */ renesas,pins = , ; }; /* SHDI ch1 on CN1 */ sdhi1_pins: sdhi1 { /* SHDI ch1 on Port 3 */ renesas,pins = , /* SDHI1 CD */ , /* SDHI1 WP */ , /* SDHI1 DAT1 */ , /* SDHI1 DAT0 */ , /* SDHI1 CLK */ , /* SDHI1 CMD */ , /* SDHI1 DAT3 */ ; /* SDHI1 DAT2 */ }; /* Ethernet */ ether_pins: ether { /* Ethernet on Ports 1,2,3,5 */ renesas,pins = , /* P1_14 = ET_COL */ , /* P5_9 = ET_MDC */ , /* P3_3 = ET_MDIO (bi dir) */ , /* P3_4 = ET_RXCLK */ , /* P3_5 = ET_RXER */ , /* P3_6 = ET_RXDV */ , /* P2_0 = ET_TXCLK */ , /* P2_1 = ET_TXER */ , /* P2_2 = ET_TXEN */ , /* P2_3 = ET_CRS */ , /* P2_4 = ET_TXD0 */ , /* P2_5 = ET_TXD1 */ , /* P2_6 = ET_TXD2 */ , /* P2_7 = ET_TXD3 */ , /* P2_8 = ET_RXD0 */ , /* P2_9 = ET_RXD1 */ , /* P2_10 = ET_RXD2 */ ; /* P2_11 = ET_RXD3 */ }; }; &i2c3 { pinctrl-names = "default"; pinctrl-0 = <&i2c3_pins>; }; &scif2 { pinctrl-names = "default"; pinctrl-0 = <&scif2_pins>; }; &sdhi1 { pinctrl-names = "default"; pinctrl-0 = <&sdhi1_pins>; }; ðer { pinctrl-names = "default"; pinctrl-0 = <ðer_pins>; }; / { leds { status = "okay"; compatible = "gpio-leds"; led1 { gpios = <&port7 1 GPIO_ACTIVE_LOW>; }; }; }; Thank you, Chris