Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965605AbdCVSfm (ORCPT ); Wed, 22 Mar 2017 14:35:42 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:37379 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965514AbdCVSfc (ORCPT ); Wed, 22 Mar 2017 14:35:32 -0400 MIME-Version: 1.0 In-Reply-To: <20170322183039.GA2899@dtor-ws> References: <1490180808-2856-1-git-send-email-jagan@openedev.com> <20170322183039.GA2899@dtor-ws> From: Jagan Teki Date: Thu, 23 Mar 2017 00:05:17 +0530 Message-ID: Subject: Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table To: Dmitry Torokhov Cc: Jagan Teki , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel , Shawn Guo , Matteo Lisi , Michael Trimarchi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 21 On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov wrote: > On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote: >> From: Jagan Teki >> >> Added missing of_match_table for max11801_ts driver with >> compatible as "maxim,max11801_ts" >> > > Why not "maxim,max11801"? Also, I think we'd need a binding document. Compatibility purpose to make this is for touchscreen and few of other *_ts.c files follow the same, and added binding documentation in 2/3 patch. thanks! -- Jagan Teki Senior Linux Kernel Engineer | Amarula Solutions U-Boot, Linux | Upstream Maintainer Hyderabad, India.