Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936037AbdCVTN1 (ORCPT ); Wed, 22 Mar 2017 15:13:27 -0400 Received: from verein.lst.de ([213.95.11.211]:45426 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935995AbdCVTNS (ORCPT ); Wed, 22 Mar 2017 15:13:18 -0400 Date: Wed, 22 Mar 2017 20:05:54 +0100 From: Christoph Hellwig To: Dmitry Monakhov Cc: linux-kernel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH] block: Invalidate cache on discard Message-ID: <20170322190554.GA6012@lst.de> References: <1490193028-4445-1-git-send-email-dmonakhov@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490193028-4445-1-git-send-email-dmonakhov@openvz.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 269 Lines: 10 On Wed, Mar 22, 2017 at 06:30:28PM +0400, Dmitry Monakhov wrote: > + > + mapping = bdev->bd_inode->i_mapping; move this assignment to the declaration of mapping at the beginning of the function? Otherwise this looks fine: Reviewed-by: Christoph Hellwig