Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754598AbdCVXoX (ORCPT ); Wed, 22 Mar 2017 19:44:23 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:34098 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbdCVXoU (ORCPT ); Wed, 22 Mar 2017 19:44:20 -0400 MIME-Version: 1.0 In-Reply-To: References: <1490204005-2733-1-git-send-email-joro@8bytes.org> <1490204005-2733-4-git-send-email-joro@8bytes.org> <2232546.0OJbVJtxLm@aspire.rjw.lan> <20170322225853.GH8329@suse.de> From: "Rafael J. Wysocki" Date: Thu, 23 Mar 2017 00:44:18 +0100 X-Google-Sender-Auth: 3DGCpBPU4I9UmI19UY5b-e8kui8 Message-ID: Subject: Re: [PATCH 3/3] ACPI: Don't create a platform_device for IOAPIC/IOxAPIC To: "Rafael J. Wysocki" Cc: Joerg Roedel , "Rafael J. Wysocki" , Joerg Roedel , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 29 On Thu, Mar 23, 2017 at 12:41 AM, Rafael J. Wysocki wrote: > On Wed, Mar 22, 2017 at 11:58 PM, Joerg Roedel wrote: >> Hi Rafael, >> >> On Wed, Mar 22, 2017 at 06:42:39PM +0100, Rafael J. Wysocki wrote: >>> On Wednesday, March 22, 2017 06:33:25 PM Joerg Roedel wrote: >>> > From: Joerg Roedel >>> > >>> > No platform-device is required for IO(x)APICs, so don't even >>> > create them. >>> > >>> > Signed-off-by: Joerg Roedel >>> >>> If we do this, I'd prefer not to do [2/3], because we'll introduce code that >>> will be essentially dead then. >> >> In this case the code in acpi_bus_attach() adding platform_devices is also >> dead. Could it be removed then? > > It is not dead. > > Platform devices are actually created by it, but they never go away. IOW, they should never be created for anything hot-removable. If they are, this is a bug (as you noticed). Thanks, Rafael