Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755437AbdCWBKj (ORCPT ); Wed, 22 Mar 2017 21:10:39 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:32820 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755395AbdCWBKT (ORCPT ); Wed, 22 Mar 2017 21:10:19 -0400 MIME-Version: 1.0 In-Reply-To: <20170323002701.GA90470@beast> References: <20170323002701.GA90470@beast> From: "Rafael J. Wysocki" Date: Thu, 23 Mar 2017 02:10:12 +0100 X-Google-Sender-Auth: -3MM_ks8xoFzkzi1McvF36JbyQI Message-ID: Subject: Re: [PATCH] hibernation: on 32-bit x86, disabled in favor of KASLR To: Kees Cook Cc: "Rafael J. Wysocki" , Pavel Machek , Evgenii Shatokhin , "open list:DOCUMENTATION" , Linux PM , Linux Kernel Mailing List , "H. Peter Anvin" , Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 16 On Thu, Mar 23, 2017 at 1:27 AM, Kees Cook wrote: > This is a modified revert of commit 65fe935dd238 ("x86/KASLR, x86/power: > Remove x86 hibernation restrictions"), since it appears that 32-bit > hibernation still can't support KASLR. 64-bit is fine. Since people have > been running with KASLR by default on 32-bit since v4.8, this disables > hibernation (with a warning). Booting with "nokaslr" will disable KASLR > and enable hibernation. > > Reported-by: Evgenii Shatokhin > Signed-off-by: Kees Cook > Cc: stable@vger.kernel.org # v4.8+ LGTM Thanks, Rafael