Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932271AbdCWHh3 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Mar 2017 03:37:29 -0400
Received: from rtits2.realtek.com ([211.75.126.72]:46111 "EHLO
        rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753675AbdCWHhX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Mar 2017 03:37:23 -0400
X-SpamFilter-By: BOX Solutions SpamTrap 5.56 with qID v2N6be2I025571, This message is accepted by code: ctloc85258
From: Bard Liao <bardliao@realtek.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
CC: "broonie@kernel.org" <broonie@kernel.org>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        Oder Chiou <oder_chiou@realtek.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode
Thread-Topic: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on
 Dell XPS 9343 I2S mode
Thread-Index: AQHSoS5G+S9N2Bimuk2IJBa89nnBeaGekiiQ//+wO4CAALJ0oIAA32gAgAHdXcD//6V3gIAAnX5A
Date: Thu, 23 Mar 2017 06:33:47 +0000
Message-ID: <ABFD875FF5FB574BA706497D987D48D701C5315B@RTITEXTEMP.realtek.com.tw>
References: <20170320035831.10762-1-kai.heng.feng@canonical.com>
 <ABFD875FF5FB574BA706497D987D48D701C4E587@RTITEXTEMP.realtek.com.tw>
 <CAAd53p6rzVtV7kiBpChrHrrpTG1RhTiQbOZVU+wC1rFWeb=5ow@mail.gmail.com>
 <ABFD875FF5FB574BA706497D987D48D701C4F38E@RTITEXTEMP.realtek.com.tw>
 <CAAd53p6xiZEFvWnFt5KQU79tM9gvANHmYs=W3UKeC82Uks+ekg@mail.gmail.com>
 <ABFD875FF5FB574BA706497D987D48D701C52CFB@RTITEXTEMP.realtek.com.tw>
 <CAAd53p4Wc0jH7D+hzeSX+nRWO-c9KemyXFSJL-KM7OnQCGfvbA@mail.gmail.com>
In-Reply-To: <CAAd53p4Wc0jH7D+hzeSX+nRWO-c9KemyXFSJL-KM7OnQCGfvbA@mail.gmail.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.21.85.154]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v2N7cJeb029337
Content-Length: 1851
Lines: 53

> -----Original Message-----
> From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com]
> Sent: Thursday, March 23, 2017 12:42 PM
> To: Bard Liao
> Cc: broonie@kernel.org; lgirdwood@gmail.com; Oder Chiou;
> alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell
> XPS 9343 I2S mode
> 
> > If HPO is already muted as what we expected, it means "HPO L" and "HPO R"
> > work properly. And there is no reason we create an event to do the same
> > thing.
> 
> Can you advise me how to do a simple check on HPO L&R mute status?

You can cat /sys/kernel/debug/regmap/<bus name>/registers
And check the registers of 0x2139000 for HPOR and 0x213a000 for HPOL.
bit 15 = 1 for muted and 0 for unmuted.
for example
Mute:
2139000: 00000080
213a000: 00000080

UnMute:
2139000: 00000000
213a000: 00000000

> 
> >
> >> >>
> >> >> I found that the effect is most noticeable if the mute callback is
> >> >> associated with "LDO2" and "HP Power".
> >> >> But again, this is just what I observed.
> >> >
> >> > Could you try only associated with "LDO2"?
> >> > It makes sense that will reduce the noise if a jack is plugged in/out
> >> > when HPO is already powered up.
> >>
> >> Does it also help to reduce noise at other power events?
> >
> > I don't know. In theory, you shouldn't hear any sound when HPO
> > is muted. If you need our help for debugging, please send a mail
> > to our FAE and cc me.
> 
> Unfortunately it did happen. AMP mute did well for me and another user
> - please check the bug report link.

I know it happens. But it works fine on my Intel Ultrabook Development
System with upstream driver. So I need our FAE's help to check what
happened on Dell XPS. According to our company policy, you should
report the bug to Dell and Dell will contact our FAE if needed.