Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754638AbdCWJDs (ORCPT ); Thu, 23 Mar 2017 05:03:48 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:36569 "EHLO mail-it0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbdCWJDq (ORCPT ); Thu, 23 Mar 2017 05:03:46 -0400 MIME-Version: 1.0 In-Reply-To: <20170315174654.15128-2-john@metanate.com> References: <20170315174654.15128-1-john@metanate.com> <20170315174654.15128-2-john@metanate.com> From: Linus Walleij Date: Thu, 23 Mar 2017 10:03:44 +0100 Message-ID: Subject: Re: [PATCH v2 1/4] pinctrl: rockchip: remove unnecessary locking To: John Keeping Cc: Heiko Stuebner , Julia Cartwright , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 651 Lines: 21 On Wed, Mar 15, 2017 at 6:46 PM, John Keeping wrote: > regmap_update_bits does its own locking and everything else accessed > here is a local variable so there is no need to lock around it. > > Signed-off-by: John Keeping > Reviewed-by: Heiko Stuebner > Tested-by: Heiko Stuebner > --- > v2: > - Also remove locking in rockchip_set_schmitt() This does not apply on my "devel" branch in the pinctrl tree. Please rebase on that and resend. Since I have no patches for rockchip so far I suspect this is not even based on v4.11-rc1 so pls forward-port. Yours, Linus Walleij