Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754934AbdCWJLS (ORCPT ); Thu, 23 Mar 2017 05:11:18 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:33473 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756AbdCWJLR (ORCPT ); Thu, 23 Mar 2017 05:11:17 -0400 MIME-Version: 1.0 In-Reply-To: <1489685162-3003-1-git-send-email-patrice.chotard@st.com> References: <1489685162-3003-1-git-send-email-patrice.chotard@st.com> From: Linus Walleij Date: Thu, 23 Mar 2017 10:11:15 +0100 Message-ID: Subject: Re: [PATCH v2] pinctrl: st: add irq_request/release_resources callbacks To: Patrice CHOTARD Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Peter Griffin , Lee Jones Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 21 On Thu, Mar 16, 2017 at 6:26 PM, wrote: > From: Patrice Chotard > > When using GPIO as IRQ source, the GPIO must be configured > in INPUT. Callbacks dedicated for this was missing in > pinctrl-st driver. > > This fix the following kernel error when trying to lock a gpio > as IRQ: > > [ 7.521095] gpio gpiochip7: (PIO11): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ > [ 7.526018] gpio gpiochip7: (PIO11): unable to lock HW IRQ 6 for IRQ > [ 7.529405] genirq: Failed to request resources for 0-0053 (irq 81) on irqchip GPIO > > Signed-off-by: Patrice Chotard Patch applied for fixes. Yours, Linus Walleij