Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755218AbdCWLsK (ORCPT ); Thu, 23 Mar 2017 07:48:10 -0400 Received: from icp-osb-irony-out1.external.iinet.net.au ([203.59.1.210]:41425 "EHLO icp-osb-irony-out1.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbdCWLry (ORCPT ); Thu, 23 Mar 2017 07:47:54 -0400 X-Greylist: delayed 599 seconds by postgrey-1.27 at vger.kernel.org; Thu, 23 Mar 2017 07:47:53 EDT X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BbAQC5stNY/wOHqnwNURkBAQEBAQEBAQEBAQcBAQEBAYU8ng8BAQEDBoEEH4gViySEHYYiAoN7AQIBAQEBAQKGKQEBAQM4QRALDQsuITYGAQwGAgEBiWoDCKoHgw4mhw4NgnoBAQEBAQEBAQEBAQEBAQEBIoYJgkoIgmKCUYFLhh0FlgmGEjqOFAGPJIY/SIokiHWBWyQWCCQIhytjAYdSgi4BAQE X-IPAS-Result: A2BbAQC5stNY/wOHqnwNURkBAQEBAQEBAQEBAQcBAQEBAYU8ng8BAQEDBoEEH4gViySEHYYiAoN7AQIBAQEBAQKGKQEBAQM4QRALDQsuITYGAQwGAgEBiWoDCKoHgw4mhw4NgnoBAQEBAQEBAQEBAQEBAQEBIoYJgkoIgmKCUYFLhh0FlgmGEjqOFAGPJIY/SIokiHWBWyQWCCQIhytjAYdSgi4BAQE X-IronPort-AV: E=Sophos;i="5.36,209,1486396800"; d="scan'208";a="180993387" Subject: Re: [PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme To: afzal mohammed , Russell King - ARM Linux References: <20170317164034.4036-1-afzal.mohd.ma@gmail.com> <20170323104310.GA6941@afzalpc> Cc: Vladimir Murzin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Greg Ungerer Message-ID: <7f5317f9-f173-2503-e125-99c6f3cd81b1@uclinux.org> Date: Thu, 23 Mar 2017 21:37:48 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170323104310.GA6941@afzalpc> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 38 Hi Afzal, On 23/03/17 20:43, afzal mohammed wrote: > On Fri, Mar 17, 2017 at 10:10:34PM +0530, afzal mohammed wrote: >> Greg upon trying to boot no-MMU Kernel on ARM926EJ reported boot >> failure. He root caused it to ID_PFR1 access introduced by the >> commit mentioned in the fixes tag below. >> >> All CP15 processors need not have processor feature registers, only >> for architectures defined by CPUID scheme would have it. Hence check >> for it before accessing processor feature register, ID_PFR1. >> >> Fixes: f8300a0b5de0 ("ARM: 8647/2: nommu: dynamic exception base address setting") >> Reported-by: Greg Ungerer >> Signed-off-by: afzal mohammed > > Greg, can i add your Tested-by ? Absolutely: Tested-by: Greg Ungerer Thanks for taking care of this. Regards Greg >> --- >> >> Hi Russell, >> >> It would be good to have the fix go in during -rc, as, >> >> 1. Culprit commit went in during the last merge window >> 2. Though nothing supported in mainline is known to be broken, the >> original change needs to be modified to be reliable >