Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298AbdCWMBd (ORCPT ); Thu, 23 Mar 2017 08:01:33 -0400 Received: from mail-yw0-f181.google.com ([209.85.161.181]:32942 "EHLO mail-yw0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753427AbdCWMBb (ORCPT ); Thu, 23 Mar 2017 08:01:31 -0400 MIME-Version: 1.0 In-Reply-To: <20170323085326.20185-1-michel@daenzer.net> References: <20170316095553.1586-1-michel@daenzer.net> <20170323085326.20185-1-michel@daenzer.net> From: Daniel Stone Date: Thu, 23 Mar 2017 12:01:30 +0000 Message-ID: Subject: Re: [PATCH] drm/fb-helper: Allow var->x/yres(_virtual) < fb->width/height again To: =?UTF-8?Q?Michel_D=C3=A4nzer?= Cc: Stefan Agner , dri-devel , Linux Kernel Mailing List , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2NC1btK002508 Content-Length: 546 Lines: 17 Hi Michel, On 23 March 2017 at 08:53, Michel Dänzer wrote: > Otherwise this can also prevent modesets e.g. for switching VTs, when > multiple monitors with different native resolutions are connected. > > The depths must match though, so keep the != test for that. > > Also update the DRM_DEBUG output to be slightly more accurate, this > doesn't only affect requests from userspace. This test looks much more sensible, and also fixes VT switching for me. Reviewed-by: Daniel Stone Cheers, Daniel