Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753072AbdCWMIJ (ORCPT ); Thu, 23 Mar 2017 08:08:09 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:35297 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbdCWMIH (ORCPT ); Thu, 23 Mar 2017 08:08:07 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: References: <20170316222652.125702-1-mka@chromium.org> From: Paul Moore Date: Thu, 23 Mar 2017 08:08:05 -0400 Message-ID: Subject: Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping() To: Grant Grundler Cc: Matthias Kaehlcke , Stephen Smalley , Eric Paris , James Morris , "Serge E . Hallyn" , selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, LKML , Prarit Bhargava , David Howells , Michael Davidson , Greg Hackmann Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 46 On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler wrote: > Ping? Any feedback on this patch? It's on my list of patches to review, patience please. > On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke wrote: >> >> 'perms' will never be NULL since it isn't a plain pointer but an array >> of u32 values. >> >> This fixes the following warning when building with clang: >> >> security/selinux/ss/services.c:158:16: error: address of array >> 'p_in->perms' will always evaluate to 'true' >> [-Werror,-Wpointer-bool-conversion] >> while (p_in->perms && p_in->perms[k]) { >> >> Signed-off-by: Matthias Kaehlcke >> --- >> security/selinux/ss/services.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/security/selinux/ss/services.c >> b/security/selinux/ss/services.c >> index 082b20c78363..2f20b5f974f4 100644 >> --- a/security/selinux/ss/services.c >> +++ b/security/selinux/ss/services.c >> @@ -155,7 +155,7 @@ static int selinux_set_mapping(struct policydb *pol, >> } >> >> k = 0; >> - while (p_in->perms && p_in->perms[k]) { >> + while (p_in->perms[k]) { >> /* An empty permission string skips ahead */ >> if (!*p_in->perms[k]) { >> k++; >> -- >> 2.12.0.367.g23dc2f6d3c-goog >> > -- paul moore www.paul-moore.com