Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934857AbdCWNRy (ORCPT ); Thu, 23 Mar 2017 09:17:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38256 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbdCWNRx (ORCPT ); Thu, 23 Mar 2017 09:17:53 -0400 Date: Thu, 23 Mar 2017 14:17:37 +0100 From: Greg KH To: "Pranay Kr. Srivastava" Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, sfr@canb.auug.org.au, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH staging/speakup v3 3/3] use speakup_allocate as per required context Message-ID: <20170323131737.GA13629@kroah.com> References: <20170301075122.GA15340@kroah.com> <20170321071024.2328-1-pranjas@gmail.com> <20170321071024.2328-4-pranjas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170321071024.2328-4-pranjas@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 584 Lines: 19 On Tue, Mar 21, 2017 at 12:40:24PM +0530, Pranay Kr. Srivastava wrote: > speakup_allocate used GFP_ATOMIC for allocations > even while during initialization due to it's use > in notifier call. > > Pass GFP_ flags as well to speakup_allocate depending > on the context it is called in. > > Signed-off-by: Pranay Kr. Srivastava > --- > drivers/staging/speakup/main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) This patch didn't apply to my staging-testing branch, but the 2 others did, odd. Can you rebase it and resend? thanks, greg k-h