Date: Thu, 23 Mar 2017 13:29:13 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andrey Konovalov <andreyknvl@google.com>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>, kasan-dev@googlegroups.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kasan: report only the first error by default
Message-ID: <20170323132913.GF9287@leverpostej>
References: <20170322160647.32032-1-aryabinin@virtuozzo.com>
 <20170323114916.29871-1-aryabinin@virtuozzo.com>
 <20170323124154.GE9287@leverpostej>
 <d9be02d7-af87-208a-c51b-c890b549434b@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d9be02d7-af87-208a-c51b-c890b549434b@virtuozzo.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 891
Lines: 32

On Thu, Mar 23, 2017 at 04:06:59PM +0300, Andrey Ryabinin wrote:
> On 03/23/2017 03:41 PM, Mark Rutland wrote:

> > Rather than trying to pick an arbitrarily large number, how about we use
> > separate flags to determine whether we're in multi-shot mode, and
> > whether a (oneshot) report has been made.
> > 
> > How about the below?
>  
> Yes, it deferentially looks better.
> Can you send a patch with a changelog, or do you want me to care of it?

Would you be happy to take care of it, along with the fixup you
suggested below, as v3?

You can add my:

Signed-off-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.


> >  
> > +#include <linux/bitops.h>
> >  #include <linux/ftrace.h>
> 
> We also need <linux/init.h> for __setup().
> 
> >  #include <linux/kernel.h>
> >  #include <linux/mm.h>
> > @@ -293,6 +294,40 @@ static void kasan_report_error(struct kasan_access_info *info)