Date: Thu, 23 Mar 2017 07:08:24 -0700
From: Steven Rostedt <rostedt@goodmis.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Peter Zijlstra <peterz@infradead.org>, <mingo@kernel.org>,
        <linux-kernel@vger.kernel.org>, <juri.lelli@gmail.com>,
        <kernel-team@lge.com>
Subject: Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on
 find_lowest_rq()
Message-ID: <20170323070824.5f0ead54@vmware.local.home>
In-Reply-To: <20170323103651.GQ11100@X58A-UD3R>
References: <1490235169-370-1-git-send-email-byungchul.park@lge.com>
        <1490235169-370-3-git-send-email-byungchul.park@lge.com>
        <20170323094445.qatkzhafbhpsm6vs@hirez.programming.kicks-ass.net>
        <20170323103651.GQ11100@X58A-UD3R>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 24

On Thu, 23 Mar 2017 19:36:51 +0900
Byungchul Park <byungchul.park@lge.com> wrote:

> On Thu, Mar 23, 2017 at 10:44:45AM +0100, Peter Zijlstra wrote:
> > On Thu, Mar 23, 2017 at 11:12:49AM +0900, Byungchul Park wrote:  
> > > It would be better to avoid pushing tasks to other cpu within
> > > a SD_PREFER_SIBLING domain, instead, get more chances to check
> > > other siblings.  
> > 
> > Did you forget to post the rt equivalent to patch 1?  
> 
> No. Fortunately, rt currently works as patch 1 does.

I'm thinking that the rt and deadline search for lowest rq functions
should be merged as one.

What they are doing is looking for the rq with the lowest priority.
deadline currently doesn't care if it picks an rq with an rt task
running on it, even when there's an rq with no rt tasks that the dl task
can migrate to. The same goes with rt. It could place an RT task on an
rq running a deadline task without knowing the rt task wont be able to
run on that cpu immediately.

-- Steve