Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965445AbdCWQAM (ORCPT ); Thu, 23 Mar 2017 12:00:12 -0400 Received: from mga04.intel.com ([192.55.52.120]:52428 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965368AbdCWQAL (ORCPT ); Thu, 23 Mar 2017 12:00:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,210,1486454400"; d="scan'208";a="1126258848" Message-ID: <1490284791.5934.45.camel@linux.intel.com> Subject: Re: [PATCH] staging: media: atomisp: fix build error From: Alan Cox To: Geliang Tang , Mauro Carvalho Chehab , Greg Kroah-Hartman , =?ISO-8859-1?Q?J=E9r=E9my?= Lefaure , Varsha Rao Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 23 Mar 2017 15:59:51 +0000 In-Reply-To: <328d0eb3da461aaaa6140b1409ee7550bcec87bb.1490261279.git.geliangtang@gmail.com> References: <328d0eb3da461aaaa6140b1409ee7550bcec87bb.1490261279.git.geliangtang@gmail.com> Organization: Intel Corporation Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 443 Lines: 15 On Thu, 2017-03-23 at 21:12 +0800, Geliang Tang wrote: > Fix the following build error: > >   CC      drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.o > drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: >  error: excess elements in array initializer [-Werror] >   "i", /* ion */ >   ^~~ NAK I've sent a patch to sort this out properly we shouldn't be using string arrays for single char values to start with... Alan