DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C02EC2E6046
Subject: Re: [PATCH v1] KVM: kvm_io_bus_unregister_dev() should never fail
To: Cornelia Huck <cornelia.huck@de.ibm.com>
References: <20170323143441.5749-1-david@redhat.com>
 <20170323170635.1fb91a2c.cornelia.huck@de.ibm.com>
 <48d409b3-d584-eaa3-24ca-e7330d6fc0e1@redhat.com>
 <20170323174013.7509b714.cornelia.huck@de.ibm.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        rkrcmar@redhat.com, Dmitry Vyukov <dvyukov@google.com>,
        Marcelo Tosatti <mtosatti@redhat.com>, stable@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <a1bbe002-da95-1a05-5055-7212e7606652@redhat.com>
Date: Thu, 23 Mar 2017 18:15:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170323174013.7509b714.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 338
Lines: 15


> 
> Either that, or an early exit for bus == NULL in kvm_io_bus_destroy().
> (I think the second option is more straightforward.)

I prefer to have the checks where kvm->buses[x] is actually accessed. So
the chance of missing yet another check is easier to verify.

Will send out v2 in a couple of minutes. Thanks!

-- 

Thanks,

David