Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933607AbdCWRPO (ORCPT ); Thu, 23 Mar 2017 13:15:14 -0400 Received: from wp227.webpack.hosteurope.de ([80.237.132.234]:56606 "EHLO wp227.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753414AbdCWRPM (ORCPT ); Thu, 23 Mar 2017 13:15:12 -0400 Subject: Re: [REGRESSION] 07ec51480b5e ("virtio_pci: use shared interrupts for virtqueues") causes crashes in guest To: "Michael S. Tsirkin" , "Richard W.M. Jones" References: <43ffa887-a20d-f836-cba8-11196924d82d@redhat.com> <20170323151906.GA19376@redhat.com> <20170323184143-mutt-send-email-mst@kernel.org> Cc: Jason Wang , Laura Abbott , Christoph Hellwig , Linux Kernel Mailing List , virtualization@lists.linux-foundation.org From: Thorsten Leemhuis Message-ID: Date: Thu, 23 Mar 2017 18:15:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170323184143-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;linux@leemhuis.info;1490289311;af807cd5; X-HE-SMSGID: 1cr6KK-0006up-Jf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 19 On 23.03.2017 17:41, Michael S. Tsirkin wrote: > On Thu, Mar 23, 2017 at 03:19:07PM +0000, Richard W.M. Jones wrote: >> On Thu, Mar 23, 2017 at 01:13:50PM +0800, Jason Wang wrote: >>> >From 312859b596e83a2164a8430343d31fce2a5ad808 Mon Sep 17 00:00:00 2001 >>> From: Jason Wang >>> Date: Thu, 23 Mar 2017 13:07:16 +0800 >>> Subject: [PATCH] virtio_pci: fix out of bound access for msix_names >>> Signed-off-by: Jason Wang >> I tested this, and it does appear to fix the crashes in >> vp_modern_find_vqs. Therefore: >> Tested-by: Richard W.M. Jones > I've queued the fix, thanks everyone! Thx. Feel free to add Tested-by: Thorsten Leemhuis as a kernel with that patch works well in my reboot tests so far. Ciao, Thorsten