Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933042AbdCWRiv (ORCPT ); Thu, 23 Mar 2017 13:38:51 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:54806 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756521AbdCWRit (ORCPT ); Thu, 23 Mar 2017 13:38:49 -0400 Subject: Re: [PATCH] arc: vdk: Fix support of UIO To: Alexey Brodkin , "linux-snps-arc@lists.infradead.org" References: <1490290485-16332-1-git-send-email-abrodkin@synopsys.com> CC: "linux-kernel@vger.kernel.org" , Ruud Derwig , "stable@vger.kernel.org" , Jos van Eijndhoven From: Vineet Gupta Message-ID: Date: Thu, 23 Mar 2017 10:37:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1490290485-16332-1-git-send-email-abrodkin@synopsys.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.82] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 50 +CC Jos ! -Vineet On 03/23/2017 10:34 AM, Alexey Brodkin wrote: > MotherBoard section has its "ranges" set to 0xE000_0000-0xF000_0000. > But UIO node maps 4 different areas in different memory locations > and all outside MB's ranges. > > That obviously breaks UIO mappings in runtime. > > Signed-off-by: Alexey Brodkin > Cc: Vineet Gupta > Cc: Ruud Derwig > Cc: stable@vger.kernel.org > --- > arch/arc/boot/dts/vdk_axs10x_mb.dtsi | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi > index f0df59b23e21..459fc656b759 100644 > --- a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi > +++ b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi > @@ -112,13 +112,19 @@ > interrupts = <7>; > bus-width = <4>; > }; > + }; > > - /* Embedded Vision subsystem UIO mappings; only relevant for EV VDK */ > - uio_ev: uio@0xD0000000 { > - compatible = "generic-uio"; > - reg = <0xD0000000 0x2000 0xD1000000 0x2000 0x90000000 0x10000000 0xC0000000 0x10000000>; > - reg-names = "ev_gsa", "ev_ctrl", "ev_shared_mem", "ev_code_mem"; > - interrupts = <23>; > - }; > + /* > + * Embedded Vision subsystem UIO mappings; only relevant for EV VDK > + * > + * This node is intentionally put outside of MB above becase > + * it maps areas outside of MB's 0xEz-0xFz. > + */ > + uio_ev: uio@0xD0000000 { > + compatible = "generic-uio"; > + reg = <0xD0000000 0x2000 0xD1000000 0x2000 0x90000000 0x10000000 0xC0000000 0x10000000>; > + reg-names = "ev_gsa", "ev_ctrl", "ev_shared_mem", "ev_code_mem"; > + interrupt-parent = <&mb_intc>; > + interrupts = <23>; > }; > };