Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754651AbdCWTGV (ORCPT ); Thu, 23 Mar 2017 15:06:21 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:37100 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbdCWTGU (ORCPT ); Thu, 23 Mar 2017 15:06:20 -0400 Date: Thu, 23 Mar 2017 15:06:17 -0400 (EDT) From: Nicolas Pitre To: Daniel Lezcano cc: Peter Zijlstra , tglx@linutronix.de, linux-kernel@vger.kernel.org, rafael@kernel.org, vincent.guittot@linaro.org Subject: Re: [PATCH V8 2/3] irq: Track the interrupt timings In-Reply-To: <20170323190225.GB24630@mai> Message-ID: References: <1490290924-12958-1-git-send-email-daniel.lezcano@linaro.org> <1490290924-12958-2-git-send-email-daniel.lezcano@linaro.org> <20170323183542.xfhc4zhjxbyxar57@hirez.programming.kicks-ass.net> <20170323190225.GB24630@mai> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 543 Lines: 18 On Thu, 23 Mar 2017, Daniel Lezcano wrote: > On Thu, Mar 23, 2017 at 07:35:42PM +0100, Peter Zijlstra wrote: > > On Thu, Mar 23, 2017 at 06:42:02PM +0100, Daniel Lezcano wrote: > > > +void irq_timings_enable(void) > > > +{ > > > + static_branch_inc(&irq_timing_enabled); > > > > Do you really need counting, or do you want static_branch_enable() here? > > I put counting in order to let several subsystem to use the irq timings if it > is needed. Please avoid overengineering. This can easily be changed later if it is needed. Nicolas