Date: Thu, 23 Mar 2017 20:38:33 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-kernel@vger.kernel.org, peterz@infradead.org, rafael@kernel.org,
        vincent.guittot@linaro.org
Subject: Re: [PATCH V8 2/3] irq: Track the interrupt timings
In-Reply-To: <alpine.LFD.2.20.1703231507260.2304@knanqh.ubzr>
Message-ID: <alpine.DEB.2.20.1703232037560.3723@nanos>
References: <1490290924-12958-1-git-send-email-daniel.lezcano@linaro.org> <1490290924-12958-2-git-send-email-daniel.lezcano@linaro.org> <alpine.LFD.2.20.1703231507260.2304@knanqh.ubzr>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 750
Lines: 29

On Thu, 23 Mar 2017, Nicolas Pitre wrote:

> On Thu, 23 Mar 2017, Daniel Lezcano wrote:
> 
> > +#define IRQ_TIMINGS_SHIFT	5
> > +#define IRQ_TIMINGS_SIZE	(1 << IRQ_TIMINGS_SHIFT)
> > +#define IRQ_TIMINGS_MASK	(IRQ_TIMINGS_SIZE - 1)
> > +
> > +struct irq_timing {
> > +	u32 irq;
> > +	u64 ts;
> > +};
> > +
> > +struct irq_timings {
> > +	struct irq_timing values[IRQ_TIMINGS_SIZE]; /* our circular buffer */
> 
> This is not very space efficient because of alignment restrictions from 
> the u64 in struct irq_timing. 25% of the memory is wasted.
> 
> You could consider having two arrays instead:
> 
> 	u32 irq_values[IRQ_TIMINGS_SIZE];
> 	u64 ts_values[IRQ_TIMINGS_SIZE];

For the penalty of dirtying two cachelines instead of one.

Thanks,

	tglx