Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755494AbdCWURR (ORCPT ); Thu, 23 Mar 2017 16:17:17 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32974 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753644AbdCWURP (ORCPT ); Thu, 23 Mar 2017 16:17:15 -0400 MIME-Version: 1.0 In-Reply-To: <1490286449-19448-6-git-send-email-narmstrong@baylibre.com> References: <1490286449-19448-1-git-send-email-narmstrong@baylibre.com> <1490286449-19448-6-git-send-email-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Thu, 23 Mar 2017 21:09:52 +0100 Message-ID: Subject: Re: [RFT PATCH 5/6] pinctrl: meson: use gpio-ranges from DT To: Neil Armstrong Cc: khilman@baylibre.com, carlo@caione.org, linus.walleij@linaro.org, linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 481 Lines: 14 Hi Neil, On Thu, Mar 23, 2017 at 5:27 PM, Neil Armstrong wrote: > When trying to add a gpio-hog, we enter a weird loop where the gpio-ranges > is needed when gpiochip_add_data() is called but in the current implementation > the ranges are added from the driver afterwards. > > A simple solution is to rely on the DR gpio-ranges attribute and remove the > call to gpiochip_add_pin_range(). did you mean devicetree or DT instead of "DR"? Regards, Martin