Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756698AbdCWVDC (ORCPT ); Thu, 23 Mar 2017 17:03:02 -0400 Received: from mail-qt0-f179.google.com ([209.85.216.179]:35087 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753104AbdCWVC7 (ORCPT ); Thu, 23 Mar 2017 17:02:59 -0400 Date: Thu, 23 Mar 2017 17:02:50 -0400 From: Jon Mason To: Tobias Regnery Cc: kishon@ti.com, rjui@broadcom.com, jonmason@broadcom.com, sbranden@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: fix build error in phy-bcm-nsp-usb3 with COMPILE_TEST Message-ID: <20170323210248.GA25773@broadcom.com> References: <20170307114352.27385-1-tobias.regnery@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170307114352.27385-1-tobias.regnery@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1880 Lines: 46 On Tue, Mar 07, 2017 at 12:43:52PM +0100, Tobias Regnery wrote: > I see the following build error with COMPILE_TEST on randconfig builds: > > divers/built-in.o: In function `nsp_usb3_phy_init': > phy-bcm-nsp-usb3.c:(.text+0x4050): undefined reference to `mdiobus_write' > phy-bcm-nsp-usb3.c:(.text+0x406c): undefined reference to `mdiobus_write' > phy-bcm-nsp-usb3.c:(.text+0x4088): undefined reference to `mdiobus_write' > phy-bcm-nsp-usb3.c:(.text+0x40a4): undefined reference to `mdiobus_write' > phy-bcm-nsp-usb3.c:(.text+0x40c0): undefined reference to `mdiobus_write' > drivers/built-in.o:phy-bcm-nsp-usb3.c:(.text+0x40f2): more undefined references to `mdiobus_write' follow > drivers/built-in.o: In function `mdio_module_init': > phy-bcm-nsp-usb3.c:(.init.text+0x134): undefined reference to `mdio_driver_register' > drivers/built-in.o: In function `mdio_module_exit': > phy-bcm-nsp-usb3.c:(.exit.text+0xcc): undefined reference to `mdio_driver_unregister' > > Fix this by adding the correct Kconfig dependency. This patch looks fine, but this driver is being reverted in Kishon's "fixes" branch. See https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git/commit/?h=fixes&id=9200c6f177638909dbbaded8aeeeccbd48744400 Thanks, Jon > > Signed-off-by: Tobias Regnery > --- > drivers/phy/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index dc5277ad1b5a..10e06f0f1dce 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -512,7 +512,7 @@ config PHY_MESON8B_USB2 > > config PHY_NSP_USB3 > tristate "Broadcom NorthStar plus USB3 PHY driver" > - depends on OF && (ARCH_BCM_NSP || COMPILE_TEST) > + depends on OF && OF_MDIO && (ARCH_BCM_NSP || COMPILE_TEST) > select GENERIC_PHY > default ARCH_BCM_NSP > help > -- > 2.11.0 >