Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932997AbdCWVrn (ORCPT ); Thu, 23 Mar 2017 17:47:43 -0400 Received: from mail-yw0-f181.google.com ([209.85.161.181]:34176 "EHLO mail-yw0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbdCWVrl (ORCPT ); Thu, 23 Mar 2017 17:47:41 -0400 MIME-Version: 1.0 In-Reply-To: <1b8d62d2-9c3a-eb18-9b4b-21d2a80cebfa@ladisch.de> References: <20170313185725.144873-1-mka@chromium.org> <1b8d62d2-9c3a-eb18-9b4b-21d2a80cebfa@ladisch.de> From: Grant Grundler Date: Thu, 23 Mar 2017 14:47:39 -0700 X-Google-Sender-Auth: 9SI41VUn58_3FkcdvueOiXqOWqo Message-ID: Subject: Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned To: Clemens Ladisch Cc: Matthias Kaehlcke , Arnd Bergmann , Greg Kroah-Hartman , LKML , Grant Grundler , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 49 On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch wrote: > Matthias Kaehlcke wrote: >> The value passed by the two callers of the function is unsigned anyway. > > Indeed; and those are just simple wrappers. > >> Making the parameter unsigned fixes the following warning when building >> with clang: >> >> drivers/char/hpet.c:588:7: error: overflow converting case value to switch condition type (2149083139 to 18446744071563667459) [-Werror,-Wswitch] >> case HPET_INFO: >> ^ >> include/uapi/linux/hpet.h:18:19: note: expanded from macro 'HPET_INFO' >> ^ >> include/uapi/asm-generic/ioctl.h:77:28: note: expanded from macro '_IOR' >> ^ >> include/uapi/asm-generic/ioctl.h:66:2: note: expanded from macro '_IOC' >> (((dir) << _IOC_DIRSHIFT) | \ >> >> Signed-off-by: Matthias Kaehlcke > > Acked-by: Clemens Ladisch Any other feedback on this patch? Or has this already been added to someone's "for-linus" branch? just looking for update on patch status. cheers, grant > >> --- >> drivers/char/hpet.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c >> index 20b32bb8c2af..0d633b76c29e 100644 >> --- a/drivers/char/hpet.c >> +++ b/drivers/char/hpet.c >> @@ -574,7 +574,7 @@ static inline unsigned long hpet_time_div(struct hpets *hpets, >> } >> >> static int >> -hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg, >> +hpet_ioctl_common(struct hpet_dev *devp, unsigned int cmd, unsigned long arg, >> struct hpet_info *info) >> { >> struct hpet_timer __iomem *timer;