Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935496AbdCWX5G (ORCPT ); Thu, 23 Mar 2017 19:57:06 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:34705 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbdCWX5D (ORCPT ); Thu, 23 Mar 2017 19:57:03 -0400 MIME-Version: 1.0 In-Reply-To: <10677530-3c57-d3d9-ae9d-e29a6fcf4de7@monstr.eu> References: <1488300022-30150-1-git-send-email-agust@denx.de> <1488300022-30150-2-git-send-email-agust@denx.de> <10677530-3c57-d3d9-ae9d-e29a6fcf4de7@monstr.eu> From: Alan Tull Date: Thu, 23 Mar 2017 18:56:16 -0500 Message-ID: Subject: Re: [PATCH v4 1/2] dt: bindings: fpga: add xilinx slave-serial binding description To: Michal Simek Cc: Anatolij Gustschin , linux-fpga@vger.kernel.org, linux-kernel , "devicetree@vger.kernel.org" , Alan Tull , Moritz Fischer , Rob Herring , Mark Rutland Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3358 Lines: 96 On Thu, Mar 16, 2017 at 6:01 AM, Michal Simek wrote: > On 28.2.2017 17:40, Anatolij Gustschin wrote: >> Add dt binding documentation details for Xilinx FPGA configuration >> over slave serial interface. >> >> Signed-off-by: Anatolij Gustschin >> Acked-by: Moritz Fischer >> Acked-by: Rob Herring >> --- >> Changes in v4: >> >> - add Acked-by tags >> >> Changes in v3: >> >> - extend example to show the usage in SPI master node, connected >> to the fpga-region node >> >> Changes in v2: >> >> - correct gpios properties in example to match above description >> >> - use fpga-mgr@0 instead of fpga-spi@0 in example >> >> .../bindings/fpga/xilinx-slave-serial.txt | 44 ++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt >> >> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt >> new file mode 100644 >> index 0000000..9766f74 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt >> @@ -0,0 +1,44 @@ >> +Xilinx Slave Serial SPI FPGA Manager >> + >> +Xilinx Spartan-6 FPGAs support a method of loading the bitstream over >> +what is referred to as "slave serial" interface. >> +The slave serial link is not technically SPI, and might require extra >> +circuits in order to play nicely with other SPI slaves on the same bus. >> + >> +See https://www.xilinx.com/support/documentation/user_guides/ug380.pdf >> + >> +Required properties: >> +- compatible: should contain "xlnx,fpga-slave-serial" >> +- reg: spi chip select of the FPGA >> +- prog_b-gpios: config pin (referred to as PROGRAM_B in the manual) >> +- done-gpios: config status pin (referred to as DONE in the manual) >> + >> +Example for full FPGA configuration: >> + >> + fpga-region0 { >> + compatible = "fpga-region"; >> + fpga-mgr = <&fpga_mgr_spi>; >> + #address-cells = <0x1>; >> + #size-cells = <0x1>; >> + }; >> + >> + spi1: spi@10680 { >> + compatible = "marvell,armada-xp-spi", "marvell,orion-spi"; >> + pinctrl-0 = <&spi0_pins>; >> + pinctrl-names = "default"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + cell-index = <1>; >> + interrupts = <92>; >> + clocks = <&coreclk 0>; >> + status = "okay"; >> + >> + fpga_mgr_spi: fpga-mgr@0 { >> + compatible = "xlnx,fpga-slave-serial"; >> + spi-max-frequency = <60000000>; >> + spi-cpha; >> + reg = <0>; >> + done-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>; >> + prog_b-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>; >> + }; >> + }; >> > > Acked-by: Michal Simek Acked-by: Alan Tull > > Thanks, > Michal > > -- > Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 > w: www.monstr.eu p: +42-0-721842854 > Maintainer of Linux kernel - Xilinx Microblaze > Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs > U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs > >