Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934623AbdCXBAz (ORCPT ); Thu, 23 Mar 2017 21:00:55 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35021 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755875AbdCXBAx (ORCPT ); Thu, 23 Mar 2017 21:00:53 -0400 Message-ID: <1490317250.9687.10.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [net-next PATCH v2 2/8] tcp: Record Rx hash and NAPI ID in tcp_child_process From: Eric Dumazet To: Alexander Duyck Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sridhar.samudrala@intel.com, edumazet@google.com, davem@davemloft.net, linux-api@vger.kernel.org Date: Thu, 23 Mar 2017 18:00:50 -0700 In-Reply-To: <20170323213644.12615.27158.stgit@localhost.localdomain> References: <20170323211820.12615.88907.stgit@localhost.localdomain> <20170323213644.12615.27158.stgit@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 19 On Thu, 2017-03-23 at 14:36 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > While working on some recent busy poll changes we found that child sockets > were being instantiated without NAPI ID being set. In our first attempt to > fix it, it was suggested that we should just pull programming the NAPI ID > into the function itself since all callers will need to have it set. > > In addition to the NAPI ID change I have dropped the code that was > populating the Rx hash since it was actually being populated in > tcp_get_cookie_sock. > > Reported-by: Sridhar Samudrala > Suggested-by: Eric Dumazet > Signed-off-by: Alexander Duyck > --- Acked-by: Eric Dumazet