Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965142AbdCXBC0 (ORCPT ); Thu, 23 Mar 2017 21:02:26 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33808 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934663AbdCXBCW (ORCPT ); Thu, 23 Mar 2017 21:02:22 -0400 Message-ID: <1490317339.9687.11.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [net-next PATCH v2 3/8] net: Only define skb_mark_napi_id in one spot instead of two From: Eric Dumazet To: Alexander Duyck Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sridhar.samudrala@intel.com, edumazet@google.com, davem@davemloft.net, linux-api@vger.kernel.org Date: Thu, 23 Mar 2017 18:02:19 -0700 In-Reply-To: <20170323213651.12615.62895.stgit@localhost.localdomain> References: <20170323211820.12615.88907.stgit@localhost.localdomain> <20170323213651.12615.62895.stgit@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 716 Lines: 16 On Thu, 2017-03-23 at 14:36 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Instead of defining two versions of skb_mark_napi_id I think it is more > readable to just match the format of the sk_mark_napi_id functions and just > wrap the contents of the function instead of defining two versions of the > function. This way we can save a few lines of code since we only need 2 of > the ifdef/endif but needed 5 for the extra function declaration. > > Signed-off-by: Alexander Duyck > --- > include/net/busy_poll.h | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) Acked-by: Eric Dumazet