Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756478AbdCXBDC (ORCPT ); Thu, 23 Mar 2017 21:03:02 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34536 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbdCXBC6 (ORCPT ); Thu, 23 Mar 2017 21:02:58 -0400 Message-ID: <1490317376.9687.12.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [net-next PATCH v2 4/8] net: Change return type of sk_busy_loop from bool to void From: Eric Dumazet To: Alexander Duyck Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sridhar.samudrala@intel.com, edumazet@google.com, davem@davemloft.net, linux-api@vger.kernel.org Date: Thu, 23 Mar 2017 18:02:56 -0700 In-Reply-To: <20170323213715.12615.49246.stgit@localhost.localdomain> References: <20170323211820.12615.88907.stgit@localhost.localdomain> <20170323213715.12615.49246.stgit@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 596 Lines: 14 On Thu, 2017-03-23 at 14:37 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > >From what I can tell there is only a couple spots where we are actually > checking the return value of sk_busy_loop. As there are only a few > consumers of that data, and the data being checked for can be replaced > with a check for !skb_queue_empty() we might as well just pull the code > out of sk_busy_loop and place it in the spots that actually need it. > > Signed-off-by: Alexander Duyck > --- Acked-by: Eric Dumazet