Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932408AbdCXEik (ORCPT ); Fri, 24 Mar 2017 00:38:40 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33892 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932085AbdCXEi3 (ORCPT ); Fri, 24 Mar 2017 00:38:29 -0400 Message-ID: <1490330296.9687.39.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [net-next PATCH v2 5/8] net: Track start of busy loop instead of when it should end From: Eric Dumazet To: Alexander Duyck Cc: Netdev , "linux-kernel@vger.kernel.org" , "Samudrala, Sridhar" , Eric Dumazet , David Miller , Linux API Date: Thu, 23 Mar 2017 21:38:16 -0700 In-Reply-To: <1490329655.9687.33.camel@edumazet-glaptop3.roam.corp.google.com> References: <20170323211820.12615.88907.stgit@localhost.localdomain> <20170323213742.12615.85793.stgit@localhost.localdomain> <1490318682.9687.22.camel@edumazet-glaptop3.roam.corp.google.com> <1490329655.9687.33.camel@edumazet-glaptop3.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 570 Lines: 19 On Thu, 2017-03-23 at 21:27 -0700, Eric Dumazet wrote: > If you believe min/max values should be added to the sysctls, because we > do not trust root anymore, please send patches only addressing that. extern unsigned int sysctl_net_busy_read; extern unsigned int sysctl_net_busy_poll; ... unsigned int sk_ll_usec; These are unsigned values, so no min/max would be required, only maybe use proc_douintvec() instead of proc_dointvec() as most sysctls use because we were lazy and had to wait linux-4.8 to actually get proc_douintvec() in the kernel ;)