Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932146AbdCXFY1 (ORCPT ); Fri, 24 Mar 2017 01:24:27 -0400 Received: from mail.kernel.org ([198.145.29.136]:45504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754389AbdCXFYT (ORCPT ); Fri, 24 Mar 2017 01:24:19 -0400 Date: Fri, 24 Mar 2017 13:23:28 +0800 From: Shawn Guo To: Jagan Teki Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Matteo Lisi , Michael Trimarchi , Jagan Teki Subject: Re: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec node Message-ID: <20170324052324.GF30608@dragon> References: <1490204897-14525-1-git-send-email-jagan@openedev.com> <1490204897-14525-8-git-send-email-jagan@openedev.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490204897-14525-8-git-send-email-jagan@openedev.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2499 Lines: 92 On Wed, Mar 22, 2017 at 11:18:12PM +0530, Jagan Teki wrote: > From: Jagan Teki > > Add support for Sound card and related codec(via i2c1) nodes > on Engicam Is.IoT MX6UL variant module boards. > > Cc: Shawn Guo > Cc: Matteo Lisi > Cc: Michael Trimarchi > Signed-off-by: Jagan Teki > --- > arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 11 +++++++++++ > arch/arm/boot/dts/imx6ul-isiot.dtsi | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 41 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi > index b149b5e..c79fa42 100644 > --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi > +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi > @@ -41,6 +41,17 @@ > */ > > &i2c1 { > + codec: sgtl5000@0a { sgtl5000: codec@a { > + compatible = "fsl,sgtl5000"; > + reg = <0x0a>; > + clocks = <&clks IMX6UL_CLK_OSC>; > + clock-names = "mclk"; > + wlf,shared-lrclk; This is a property for wm8960 not sgtl5000. > + VDDA-supply = <®_3p3v>; > + VDDIO-supply = <®_3p3v>; > + VDDD-supply = <®_1p8v>; > + }; > + > touch: stmpe811@44 { > compatible = "st,stmpe811"; > reg = <0x44>; > diff --git a/arch/arm/boot/dts/imx6ul-isiot.dtsi b/arch/arm/boot/dts/imx6ul-isiot.dtsi > index ea30380..7cbcaea 100644 > --- a/arch/arm/boot/dts/imx6ul-isiot.dtsi > +++ b/arch/arm/boot/dts/imx6ul-isiot.dtsi > @@ -69,6 +69,36 @@ > 100>; > default-brightness-level = <100>; > }; > + > + reg_1p8v: regulator-1p8v { > + compatible = "regulator-fixed"; > + regulator-name = "1P8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + reg_3p3v: regulator-3p3v { > + compatible = "regulator-fixed"; > + regulator-name = "3P3V"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + sound { > + compatible = "fsl,imx-audio-sgtl5000"; > + model = "imx6ul-isiot-sgtl5000"; > + cpu-dai = <&sai2>; > + audio-codec = <&codec>; > + gpr = <&gpr>; I do not see this 'gpr' thing in bindings/sound/imx-audio-sgtl5000.txt. Shawn > + audio-routing = > + "MIC_IN", "Mic Jack", > + "Mic Jack", "Mic Bias", > + "Headphone Jack", "HP_OUT"; > + }; > }; > > &i2c1 { > -- > 1.9.1 >